layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

fix: responsive and alignment issue on career/internship page

Open upsaurav12 opened this issue 1 year ago β€’ 7 comments

Description

This PR fixes #5997 While working on this issue i have fixed the responsive issue of cards for mobile views(<450px). Some issues were already fixed by someone else hence responsive issues on live website is not in local.

https://github.com/user-attachments/assets/b4fa6a84-0c32-4cc6-8769-0744a001e1b1

Notes for Reviewers

Signed commits

  • [x] Yes, I signed my commits.

upsaurav12 avatar Oct 19 '24 17:10 upsaurav12

@vishalvivekm for careers/internship it is almost fixed. but for the route campany/brand in local env that issue is not present as it is already fixed by someone. But i see some mis-alignment issues like the label of logo is not aligned , size of images are too larger for a mobile view.

https://github.com/user-attachments/assets/04dc282b-88bf-4c73-a234-34228cb95a58

upsaurav12 avatar Oct 19 '24 17:10 upsaurav12

πŸš€ Preview for commit 18e5679e2b7b06734cf65a7de0a7d5b459aaa897 at: https://6713eb85bf1db5f032b32bf6--layer5.netlify.app

l5io avatar Oct 19 '24 17:10 l5io

πŸš€ Preview for commit af4b8ec1c8272cec678de103243d3172e48532ab at: https://6714a9bbc5a1569e8c49f1ad--layer5.netlify.app

l5io avatar Oct 20 '24 06:10 l5io

πŸš€ Preview for commit c95b0a26615ef7b6156c8b85327147184279a248 at: https://6714ecd2086477df19b795ea--layer5.netlify.app

l5io avatar Oct 20 '24 11:10 l5io

@upsaurav12 Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

vishalvivekm avatar Oct 21 '24 01:10 vishalvivekm

πŸš€ Preview for commit 2b03cb96f4e0f2363372a6cf521faf387c825876 at: https://67164cc98c4e2827597f2af9--layer5.netlify.app

l5io avatar Oct 21 '24 12:10 l5io

image @vishalvivekm In localhost i am getting this error in my local envirement(gitpod)

upsaurav12 avatar Oct 21 '24 14:10 upsaurav12

πŸš€ Preview for commit 88ca4f1a9bfca9ffa38a1bb437b3eba9eaf1f451 at: https://6722274400d5ef9785e830f2--layer5.netlify.app

l5io avatar Oct 30 '24 12:10 l5io

image @vishalvivekm In localhost i am getting this error in my local envirement(gitpod)

@upsaurav12 were you able to get past this issue ?

vishalvivekm avatar Nov 03 '24 15:11 vishalvivekm

I still getting this issue even i tried to update branch

upsaurav12 avatar Nov 03 '24 15:11 upsaurav12

I still getting this issue even i tried to update branch

please once run make clean and let's see, if this resolves it.

vishalvivekm avatar Nov 03 '24 16:11 vishalvivekm

@vishalvivekm on make setup command i am getting these error image I am on my gitpod and I tried to make new workspace but i got this error while doing tsetup

upsaurav12 avatar Nov 03 '24 16:11 upsaurav12

πŸš€ Preview for commit 4a244a62264541b5415b1e412854e3f858ee3f48 at: https://6727a05660b79d4998b6c24f--layer5.netlify.app

l5io avatar Nov 03 '24 16:11 l5io

@vishalvivekm i tried to run make clean and make build image

upsaurav12 avatar Nov 03 '24 16:11 upsaurav12

@vishalvivekm on make setup command i am getting these error image I am on my gitpod and I tried to make new workspace but i got this error while doing tsetup

@upsaurav12 It’s likely that these errors are due to incompatible mdx plugin dependencies which require an upgrade. ref: https://github.com/layer5io/layer5/pull/6014 https://github.com/layer5io/layer5/pull/4585 The make setup command (which we use to install required dependencies) accounts for this by adding the --legacy-peer-deps flag to the npm install command:

https://github.com/layer5io/layer5/blob/360f6702cff6163381aefce5bdfe923ded012863/Makefile#L22

vishalvivekm avatar Nov 03 '24 16:11 vishalvivekm

@vishalvivekm i tried to run make clean and make build image

[!Note] make clean expects Gatsby cli to be installed on the machine. It can be installed using npm install -g gatsby-cli

Once you install gatsby cli, let’s execute the following commands in sequence:

rm -rf node_modules/
rm -rf .cache/
make setup
make clean

vishalvivekm avatar Nov 03 '24 16:11 vishalvivekm

@vishalvivekm thank you so much now setup is working. but i just updated the branch 1hour ago why it is still showing the branch is behind?

upsaurav12 avatar Nov 03 '24 17:11 upsaurav12

@vishalvivekm, while seeing the responsive of positions it is now same as in live website. but initially it wasnt there what the reason for this?

upsaurav12 avatar Nov 03 '24 17:11 upsaurav12

πŸš€ Preview for commit 3526a3b3eec08d20799c02e54f59d95c90ee0aba at: https://67289b412a603e42c4802087--layer5.netlify.app

l5io avatar Nov 04 '24 10:11 l5io

@vishalvivekm i have fixed the issue in both pages careers/internships and company/brand.

upsaurav12 avatar Nov 04 '24 12:11 upsaurav12

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 01:04 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Apr 27 '25 03:04 stale[bot]