layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Convert all png of sections directory to webp

Open Mandeep56Singh opened this issue 1 year ago • 14 comments

Description

This PR fixes ##5854

Notes for Reviewers it converts all the png under src/sections directory to webP and it resolves path

Signed commits

  • [ x] Yes, I signed my commits.

Mandeep56Singh avatar Sep 23 '24 21:09 Mandeep56Singh

I am waiting for your feedback

Mandeep56Singh avatar Sep 23 '24 21:09 Mandeep56Singh

🚀 Preview for commit b11dd869589131919ae05b23eef34595fd4f3f72 at: https://66f1dadb46884513f1110169--layer5.netlify.app

l5io avatar Sep 23 '24 21:09 l5io

@Mandeep56Singh will you sign your commits.

sudhanshutech avatar Sep 25 '24 15:09 sudhanshutech

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Sep 25 '24 15:09 github-actions[bot]

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Sep 25 '24 15:09 github-actions[bot]

@sudhanshutech looks like I maded a mistake 😅 in commit history I forget to update the branch, and simply push the commit history

is it a problem ? is there a way to fix it ?

Mandeep56Singh avatar Sep 25 '24 17:09 Mandeep56Singh

@sudhanshutech yes space has saved from 9.3mb to 1.4mb Before Screenshot (485)

after Screenshot (484)

Mandeep56Singh avatar Sep 25 '24 18:09 Mandeep56Singh

🚀 Preview for commit d7d869903de83a77cc3bca1b1370c1e36d2315d3 at: https://66f451d19b40483e1f18f91c--layer5.netlify.app

l5io avatar Sep 25 '24 18:09 l5io

Thank you for your contribution @Mandeep56Singh Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

vishalvivekm avatar Sep 30 '24 04:09 vishalvivekm

@vishalvivekm sorry, I wasn't able to attend the meeting, please tell if this pr need changes. I am not able to see the changes requested by @sudhanshutech.

Mandeep56Singh avatar Oct 02 '24 11:10 Mandeep56Singh

🚀 Preview for commit 01a808e5b46681b6e22d12de06bc30d235e518be at: https://66fd31a32515e4d7ee2ba398--layer5.netlify.app

l5io avatar Oct 02 '24 11:10 l5io

@Mandeep56Singh you might have rebased the commit please revert those changes. Either you can create a new pr and closing this one and in the new pr update to webp in chunks and not every images in same pr.

sudhanshutech avatar Oct 09 '24 10:10 sudhanshutech

@Mandeep56Singh ?

sudhanshutech avatar Oct 14 '24 13:10 sudhanshutech

@sudhanshutech looks like I maded a mistake 😅 in commit history I forget to update the branch, and simply push the commit history

is it a problem ? is there a way to fix it ?

@sudhanshutech please tell me, how to fix the mistake I created.

Mandeep56Singh avatar Oct 15 '24 12:10 Mandeep56Singh

you can create a new pr and create prs in chunks that is take lee number of file changes and in iterative way

sudhanshutech avatar Nov 23 '24 14:11 sudhanshutech

please open a new pr at will

sudhanshutech avatar Nov 23 '24 14:11 sudhanshutech