layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Published 20 hours ago • verified publisher icon layer5io

Input Search Dark Mode Friendly

Open THEBOSS0369 opened this issue 1 year ago • 27 comments

This PR fixes #5734

Description

I have added some changes so that the input looks like more dark friendly. The changes for style has been done for Intergration Page, Home Page and Blog Page. The style is same as the style in layer5/news page. Below are the ss for the changes made.

main page main page blog

Notes for Reviewers This PR is same as this one https://github.com/layer5io/layer5/pull/5881 . It is made because of DCO error not resolving.

Signed commits

  • [x] Yes, I signed my commits.

THEBOSS0369 avatar Sep 15 '24 11:09 THEBOSS0369

🚀 Preview for commit ae8e3af6ad52218ab114f1fec426514e79edf407 at: https://66e6cb30f79a9a88c715ccb7--layer5.netlify.app

l5io avatar Sep 15 '24 11:09 l5io

@THEBOSS0369, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

I'm adding it as an agenda item to the meeting minutes || meeting link.

ashparshp avatar Sep 16 '24 03:09 ashparshp

@THEBOSS0369 Sharing the links form our discussion in websites meeting

  • https://github.com/layer5io/layer5/blob/b0d781f24c3f323b96a772c61b8446a291896cb2/src/sections/Company/News-grid/NewsGrid.style.js#L102
  • https://github.com/layer5io/layer5/blob/master/CONTRIBUTING.md#things-to-keep-in-mind-1

vishalvivekm avatar Sep 16 '24 16:09 vishalvivekm

Also, will you please remove commits not pertinent to the issue ?

vishalvivekm avatar Sep 16 '24 16:09 vishalvivekm

@THEBOSS0369 Sharing the links form our discussion in websites meeting

  • https://github.com/layer5io/layer5/blob/b0d781f24c3f323b96a772c61b8446a291896cb2/src/sections/Company/News-grid/NewsGrid.style.js#L102
  • https://github.com/layer5io/layer5/blob/master/CONTRIBUTING.md#things-to-keep-in-mind-1

Thanks for sharing this!! 🙂🙂

THEBOSS0369 avatar Sep 16 '24 16:09 THEBOSS0369

Also, will you please remove commits not pertinent to the issue ?

Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js

THEBOSS0369 avatar Sep 17 '24 01:09 THEBOSS0369

Also, will you please remove commits not pertinent to the issue ?

Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js

I was referring to these Commits: Screenshot_20240917-084243

vishalvivekm avatar Sep 17 '24 03:09 vishalvivekm

Also, will you please remove commits not pertinent to the issue ?

Sure! I will remove the changes from searchbox. Js and apply the changes in gridestyle. Js

I was referring to these Commits: Screenshot_20240917-084243

Ohhhh, i get it now! I didn't commited those changes but can you tell me how do i remove those commits like do i have to revert back or any other way.

THEBOSS0369 avatar Sep 17 '24 10:09 THEBOSS0369

@vishalvivekm Can you confirm that i have to do Delete File right?? image

THEBOSS0369 avatar Sep 17 '24 10:09 THEBOSS0369

Hey @vishalvivekm ! Please review the changes i made. Also, now the style is similar as the style of searchbox in /news page.

THEBOSS0369 avatar Sep 20 '24 05:09 THEBOSS0369

🚀 Preview for commit b263459fbbe55c1764dbfddf18c496752daebcee at: https://66ed04ee857b09e66702c1f3--layer5.netlify.app

l5io avatar Sep 20 '24 05:09 l5io

@THEBOSS0369 why are we still modifying the themes hex codes?

vishalvivekm avatar Sep 22 '24 17:09 vishalvivekm

@THEBOSS0369 why are we still modifying the themes hex codes?

Please review the feedback: https://m.youtube.com/watch?v=7ln7cWOHOKo&t=570s

vishalvivekm avatar Sep 22 '24 17:09 vishalvivekm

Hey @vishalvivekm ! Apologies for late reply. I got confused and wasn't able to figure out how to do it. Now I have sorted everything, I have added the style for Searchbox in Required Page's ...grid.style.js file and removed the changes from the Themestyles.js and searchbox.style.js .

Note the Changes you will see in Searchhox.style.js are the changes which I copied from the official searchbox.style.js to revert back to the original changes from the main branch.

Thanks

THEBOSS0369 avatar Sep 25 '24 07:09 THEBOSS0369

🚀 Preview for commit df81b5ec70b776de3fdd1eed81111f7332496df7 at: https://66f5bc40a708be4127521040--layer5.netlify.app

l5io avatar Sep 26 '24 19:09 l5io

@THEBOSS0369 any updates?

sudhanshutech avatar Oct 09 '24 10:10 sudhanshutech

@THEBOSS0369 any updates?

Hey @sudhanshutech ! This PR is completed and ready to merge. I had exams which ended today that's why i wasn't able. To join the meeting. Thanks

THEBOSS0369 avatar Oct 09 '24 10:10 THEBOSS0369

@THEBOSS0369 there was gatsby upgrade in site please ensure you changes again that it works.

sudhanshutech avatar Oct 09 '24 10:10 sudhanshutech

🚀 Preview for commit defd7355469a972c7a5ecd23f78633d6850df5d7 at: https://6706648dbcd8ce273bf87ec6--layer5.netlify.app

l5io avatar Oct 09 '24 11:10 l5io

@sudhanshutech ! Everything is working fine i just checked it here are ss. You can also verify these changes on the preview link.

image image image

THEBOSS0369 avatar Oct 09 '24 11:10 THEBOSS0369

🚀 Preview for commit df8b9487c0aa0c2259754e8f89404a76a1bfe03c at: https://67066a3e750f902dccf909cf--layer5.netlify.app

l5io avatar Oct 09 '24 11:10 l5io

{ACFBDB30-87EE-48D7-9355-82A42F85CF69} this search icon should also be a white shade as well

@sudhanshutech ! The style is same as in Layer5/news section and @vishalvivekm told me to copy the same style. Although I agree that it should be white. If you both agree to that I will change it to white.

THEBOSS0369 avatar Oct 14 '24 14:10 THEBOSS0369

{ACFBDB30-87EE-48D7-9355-82A42F85CF69} this search icon should also be a white shade as well

@sudhanshutech ! The style is same as in Layer5/news section and @vishalvivekm told me to copy the same style. Although I agree that it should be white. If you both agree to that I will change it to white.

yes please , for light mode it could stay the same but for dark mode a white shade. See if there other icons which do the same like dark shade for light mode and white shade for dark mode and do the same

sudhanshutech avatar Oct 14 '24 14:10 sudhanshutech

@sudhanshutech @vishalvivekm ! I have removed the code from the required searchbox's respective files and add it to the global styles so that in future we don't have to copy paste the whole code and changed the icon's color from black to white as you told me. Note: I have also removed the code from the News Section as well.

I hope this PR is in its ending phase now.

Here are the Results!

Screenshot 2024-10-17 121657 Screenshot 2024-10-17 121755 Screenshot 2024-10-17 121831 Screenshot 2024-10-17 121912 Screenshot 2024-10-17 122034

THEBOSS0369 avatar Oct 17 '24 07:10 THEBOSS0369

🚀 Preview for commit 68e48e9fdd393aac2f0083d3dbdd8ff7593b670a at: https://6710b9a97d9bdaacec91dbd0--layer5.netlify.app

l5io avatar Oct 17 '24 07:10 l5io

🚀 Preview for commit 26dd7b6a429bf8bf7cf94cf552986fd246027c88 at: https://67134b3657a13b407c38a272--layer5.netlify.app

l5io avatar Oct 19 '24 06:10 l5io

🚀 Preview for commit 68842882b272557c634b23a7f729eb58ec2b311b at: https://671632d73284890bdad28f2c--layer5.netlify.app

l5io avatar Oct 21 '24 10:10 l5io

Hey @sudhanshutech @vishalvivekm ! I have done the changes you asked. Please look into it and i hope this is the last thing i needed to change. Thanks

image image

THEBOSS0369 avatar Oct 22 '24 12:10 THEBOSS0369

🚀 Preview for commit 433f23a42343cf140f1a0d58be12ee82ba6b0810 at: https://67179bdbb7a10f10183228ff--layer5.netlify.app

l5io avatar Oct 22 '24 12:10 l5io

🚀 Preview for commit 59368e32dfc09284a1faa0a3c84a72d33b6467da at: https://671ccd0237fc879c50759566--layer5.netlify.app

l5io avatar Oct 26 '24 11:10 l5io