layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Feature/integrations columns

Open Npcodes1 opened this issue 1 year ago • 32 comments

Description

This PR fixes #5514. In the Home section of the src folder, I made edits to the index.js in the Playground-home folder. I added animation so that the icons in the integrations column would shift to a horizontal flow in mobile screen size, while still remaining vertical in tablet/desktop size.

Notes for Reviewers

Signed commits

  • [x] Yes, I signed my commits.

Npcodes1 avatar Sep 07 '24 03:09 Npcodes1

🚀 Preview for commit e4fb8e1d86f53c0c5f9b027e95ed9a4cb87d7317 at: https://66dbcf875e74a09f11ebd0e5--layer5.netlify.app

l5io avatar Sep 07 '24 04:09 l5io

@Npcodes1, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link.

ashparshp avatar Sep 07 '24 15:09 ashparshp

@Ashparshp Thank you! I’m unable to make the meeting due to work but should I add it to the minutes anyways to be discussed without me? Also, do I need to worry about the MeshMap Screenshot Service failing?

Npcodes1 avatar Sep 07 '24 18:09 Npcodes1

@Npcodes1,

Thank you for your contribution! It’s great to see your updates. If you can’t attend the meeting, please do add the PR to the meeting minutes so it can be discussed in your absence. As for the failing MeshMap Screenshot Service, don’t worry about it—it’s not an issue related to your changes.

ashparshp avatar Sep 07 '24 18:09 ashparshp

@Npcodes1, you've done a great job with the changes! Just a small request—please avoid altering linting like spaces or tabs, as it makes it a bit harder to review. It would be helpful to keep only the functional changes.

ashparshp avatar Sep 09 '24 12:09 ashparshp

Ok! Do I need to go make any changes?

Npcodes1 avatar Sep 09 '24 13:09 Npcodes1

@Npcodes1, please if you would then just update the functional changes and nothing.

ashparshp avatar Sep 09 '24 14:09 ashparshp

I updated it. Does this look better now? @Ashparshp

Npcodes1 avatar Sep 10 '24 05:09 Npcodes1

🚀 Preview for commit e5d7185fed0ff930231b81fab50e2abd72d98ae1 at: https://66dfdc7fac854a05d3eeb0d9--layer5.netlify.app

l5io avatar Sep 10 '24 05:09 l5io

@sahu-01

vishalvivekm avatar Sep 10 '24 14:09 vishalvivekm

Thank you so much for working on this @Npcodes1 , once you remove the commented code I believe we'll be really close to merging this PR 😉

SAHU-01 avatar Sep 13 '24 04:09 SAHU-01

@SAHU-01 Ok! I made changes but it rejected me using git push because my branch isn't up to date to the main one. It gave these suggestions. Does it matter which one I choose? git config pull.rebase false # merge git config pull.rebase true # rebase git config pull.ff only # fast-forward only

Npcodes1 avatar Sep 13 '24 23:09 Npcodes1

@Npcodes1, use git config pull.rebase true.

ashparshp avatar Sep 14 '24 12:09 ashparshp

Ok! Commented code has been removed. Please let me know if I missed anything.

Npcodes1 avatar Sep 16 '24 06:09 Npcodes1

🚀 Preview for commit d109db0c0b754035d39ac872d237b4e663b84014 at: https://66e7d8fc23e323c810880fd2--layer5.netlify.app

l5io avatar Sep 16 '24 07:09 l5io

I realized I forgot to sign my commit so I was going to do another commit but now I can't seem to run locally off Gitpod. It's giving me this error: image

Npcodes1 avatar Sep 16 '24 07:09 Npcodes1

I realized I forgot to sign my commit so I was going to do another commit but now I can't seem to run locally off Gitpod. It's giving me this error: image

please try running make clean

vishalvivekm avatar Sep 16 '24 11:09 vishalvivekm

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Sep 16 '24 11:09 github-actions[bot]

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Sep 16 '24 11:09 github-actions[bot]

🚀 Preview for commit b9a756c49f3bf2a527fdb94c17024b1a5dac1ecf at: https://66e9031e95a9cf7aa5e30ab7--layer5.netlify.app

l5io avatar Sep 17 '24 04:09 l5io

🚀 Preview for commit 1bf546bbb3e652f25b15251ec6730db19b8ceeda at: https://66e90c6ede7b3f970c80c892--layer5.netlify.app

l5io avatar Sep 17 '24 04:09 l5io

I fixed it.

Npcodes1 avatar Sep 17 '24 05:09 Npcodes1

@Ashparshp @SAHU-01 @vishalvivekm To resolve the conflicts should I change it to the master version (v0.2.12)?

image

Npcodes1 avatar Sep 20 '24 05:09 Npcodes1

@Npcodes1, Keep the version @v0.2.12

ashparshp avatar Sep 20 '24 14:09 ashparshp

🚀 Preview for commit 93afc0694341e6810f6efe8c13a592e83fe704c8 at: https://66ee3f803e2f92c861948de0--layer5.netlify.app

l5io avatar Sep 21 '24 03:09 l5io

@Ashparshp Ok, thanks. Everything's been resolved.

Npcodes1 avatar Sep 21 '24 04:09 Npcodes1

@vishalvivekm //

ashparshp avatar Sep 23 '24 11:09 ashparshp

@Npcodes1 there is update in gatsby now so please kindly re ensure your fix if it still working.

sudhanshutech avatar Oct 09 '24 10:10 sudhanshutech

🚀 Preview for commit dac708c866562ab128ff5e002cae9b12cd2ec19b at: https://6706630f07f33823ee177898--layer5.netlify.app

l5io avatar Oct 09 '24 11:10 l5io

@Npcodes1 there is update in gatsby now so please kindly re ensure your fix if it still working.

@sudhanshutech Ok. How do I do the update?

Npcodes1 avatar Oct 15 '24 01:10 Npcodes1