layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Improved the UI of ebpf and other svg's for better visibility in dark mode

Open Suswetha6 opened this issue 1 year ago • 10 comments

Description

This PR fixes #5070

Notes for Reviewers I've added a new property in the theme objects in themeStyles.js and updated the css of svg in meshmap section.

Signed commits

  • [x] Yes, I signed my commits.

Suswetha6 avatar Aug 15 '24 06:08 Suswetha6

🚀 Preview for commit a486635f3ef731735081191dc4c0b1d05a03ddfe at: https://66bda7570d0bf57b1954d8ab--layer5.netlify.app

l5io avatar Aug 15 '24 07:08 l5io

Hey @Suswetha6 please sign the commits using -s , now you need to rebase and squash them

narasimha-1511 avatar Aug 15 '24 19:08 narasimha-1511

Screenshot 2024-08-16 at 2 26 54 AM

You should not add the boder box or something kindly change the svg itself which appears better in the dark mode

narasimha-1511 avatar Aug 15 '24 20:08 narasimha-1511

@narasimha-1511, do we have a svg for this? and @Suswetha6, please fix the DCO sign-off. If you're unaware, read more about it in the contributing guide.

ashparshp avatar Aug 16 '24 05:08 ashparshp

@Suswetha6, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

ashparshp avatar Aug 19 '24 06:08 ashparshp

@Suswetha6, please join. The meeting has started.

ashparshp avatar Aug 19 '24 12:08 ashparshp

@Suswetha6, any luck?

ashparshp avatar Aug 21 '24 05:08 ashparshp

@Suswetha6, checking again?

ashparshp avatar Aug 22 '24 03:08 ashparshp

Hey @narasimha-1511 , sorry i was not available. I am not sure how to do the DCO sign-off, i will read about it and do it by eod

Suswetha6 avatar Aug 22 '24 06:08 Suswetha6

🚀 Preview for commit 0aada74a41115d3bad8b8e09a0738bdb4ea6ed14 at: https://66c6e5c9cde1b814330e07c2--layer5.netlify.app

l5io avatar Aug 22 '24 07:08 l5io

@Suswetha6, any update?

ashparshp avatar Aug 31 '24 19:08 ashparshp