layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

[UI] Invalid read more button removed.

Open SyedAyaanAli6786 opened this issue 1 year ago • 10 comments

Description

This PR fixes #5814 using conditional rendering .

Notes for Reviewers

Signed commits

  • [x ] Yes, I signed my commits.

SyedAyaanAli6786 avatar Aug 14 '24 19:08 SyedAyaanAli6786

🚀 Preview for commit 5f8ee23c682474bc556a9a10eb2fae3f911f3a61 at: https://66bd0f714adcc41c087bdfef--layer5.netlify.app

l5io avatar Aug 14 '24 20:08 l5io

🚀 Preview for commit 35fc5583e3e7348f7dd58ef371328270d84166d9 at: https://66bf2bcbc24898ffdb946be1--layer5.netlify.app

l5io avatar Aug 16 '24 10:08 l5io

@SyedAyaanAli6786, Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

ashparshp avatar Aug 19 '24 06:08 ashparshp

@SyedAyaanAli6786, please join. The meeting has started.

ashparshp avatar Aug 19 '24 12:08 ashparshp

@Ashparshp Hello, I didn't saw this message of yours. I was a little busy today. I will surely join the next meeting.

SyedAyaanAli6786 avatar Aug 19 '24 15:08 SyedAyaanAli6786

Thank you @SyedAyaanAli6786 for sending words, are you on slack?

ashparshp avatar Aug 21 '24 05:08 ashparshp

No @Ashparshp currently I'm not on slack, but I can join if you say.

SyedAyaanAli6786 avatar Aug 21 '24 17:08 SyedAyaanAli6786

@SyedAyaanAli6786, yes please!

ashparshp avatar Aug 21 '24 18:08 ashparshp

@SyedAyaanAli6786, Joined? and also, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

ashparshp avatar Aug 26 '24 08:08 ashparshp

Yes @Ashparshp joined slack.

SyedAyaanAli6786 avatar Aug 26 '24 13:08 SyedAyaanAli6786

@vishalvivekm, the ask was to remove the read more as it was invalid here. Please recheck the issue again.

ashparshp avatar Aug 31 '24 22:08 ashparshp

@SyedAyaanAli6786, Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT). Please consider adding it as an agenda item to the meeting minutes || meeting link.

ashparshp avatar Sep 09 '24 07:09 ashparshp

I'm adding this as an agenda item to the meeting minutes. Please join the evening call.

ashparshp avatar Sep 09 '24 07:09 ashparshp

Ok @Ashparshp, thanks for the invitation. I will be there at the meeting. Can you tell me what will be my role in the meeting (what will I tell) ?

SyedAyaanAli6786 avatar Sep 09 '24 08:09 SyedAyaanAli6786

In the meeting, we discussed the PRs and updates on the work and provide feedback. This is the fastest way to move forward with the PRs.

ashparshp avatar Sep 09 '24 08:09 ashparshp

@SyedAyaanAli6786, any luck?

ashparshp avatar Sep 14 '24 12:09 ashparshp

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Sep 30 '24 04:09 github-actions[bot]

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Sep 30 '24 04:09 github-actions[bot]

🚀 Preview for commit 2f0c04e1997b5e76000aa7d1edc9caf30e05cb08 at: https://670d2104e3e68c3792cfe3ee--layer5.netlify.app

l5io avatar Oct 14 '24 13:10 l5io

lgtm. @SyedAyaanAli6786 please ensure next time you get assigned for the issue before creating a pr.

sudhanshutech avatar Oct 14 '24 13:10 sudhanshutech