layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Dark-mode friendly support for search input field

Open leecalcote opened this issue 1 year ago β€’ 10 comments

Current Behavior

See the https://layer5.io/blog page and it's use of an input field while in dark mode. See also the site home page and https://layer5.io/cloud-native-management/meshery/integrations for additional uses of a search input field.

Be sure to adhere to the Acceptance Tests below.

Desired Behavior

Screenshot 2024-07-26 at 4 50 08β€―PM

Acceptance Tests

  1. All search input fields for follow the same dark-mode friendly behavior.
    1. Integrations page
    2. Home page
    3. Blog page

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

leecalcote avatar Jul 26 '24 21:07 leecalcote

hey @leecalcote I would like to work on this issue, please assign me this issue

Dipti0704 avatar Jul 27 '24 03:07 Dipti0704

hey @leecalcote please assign me this issue.

BarryByte avatar Jul 27 '24 06:07 BarryByte

Hey @leecalcote @hargunkaur286 , I'm available for this issue now and have also worked around layer5, you can assign me this

hollermay avatar Jul 27 '24 06:07 hollermay

Hey @Dipti0704 you have already working on other issue i am assigning this to @BarryByte

narasimha-1511 avatar Jul 27 '24 07:07 narasimha-1511

Thank you all for your interest in working on this issue!

I apologize for any confusion regarding the assignments. We appreciate your ask and will ensure that future assignments follow the chronological order of requests. For now, @Dipti0704, thank you for your patience. We'll proceed with the issue based on our current process and prioritize assignments accordingly.

Thanks again to @BarryByte, @Indrajeety993648, and @hollermay for your willingness to contribute.

ashparshp avatar Aug 01 '24 06:08 ashparshp

@BarryByte Any updates?

ashparshp avatar Aug 01 '24 06:08 ashparshp

Hello @Ashparshp, Sorry for the delay in discussing the approach. The issue can be fixed by implementing a dark mode switcher for the entire Blog page. Currently, the background color of the search input field is grey in light mode and white in dark mode, which is not consistent.

Refer to these images for a better understanding of the issue:

Screenshot from 2024-07-28 12-17-26 Screenshot from 2024-07-28 12-17-13

The color hex code does not change when the theme is toggled. Therefore, we need to implement separate changes for the Blog page when the theme is switched. If i am missing something please add to it.

BarryByte avatar Aug 01 '24 11:08 BarryByte

@BarryByte Refer: https://layer5.io/projects/sistent/identity/color/guidance

ashparshp avatar Aug 02 '24 14:08 ashparshp

@BarryByte any luck?

sudhanshutech avatar Aug 14 '24 07:08 sudhanshutech

@sudhanshutech Can I take up this issue?

Shubhf avatar Aug 25 '24 11:08 Shubhf

@sudhanshutech isn't there any command which can automate assigning issues to people. like .take for assigning issues ?

Mandeep56Singh avatar Aug 31 '24 14:08 Mandeep56Singh

@Mandeep56Singh, We generally provide access to assign issues to contributors who have shown consistent participation and commitment to the project. This ensures that the right people have the responsibility to manage issues effectively.

ashparshp avatar Aug 31 '24 15:08 ashparshp

@Shubhf, you have already pending issues, please get those done first.

ashparshp avatar Aug 31 '24 15:08 ashparshp

@BarryByte, as we haven't heard back from you, I've unassigned you.

ashparshp avatar Aug 31 '24 15:08 ashparshp

@Mandeep56Singh, intrested on taking?

ashparshp avatar Aug 31 '24 15:08 ashparshp

@Ashparshp hmm... ok

Mandeep56Singh avatar Aug 31 '24 17:08 Mandeep56Singh

Hey @leecalcote @Ashparshp @sudhanshutech! Can i take this issue? I can work on this. Thanks

THEBOSS0369 avatar Sep 08 '24 03:09 THEBOSS0369

@THEBOSS0369,

Go ahead please..

ashparshp avatar Sep 08 '24 03:09 ashparshp