layer5
layer5 copied to clipboard
Fix: responsiveness issue#5693
Description
This PR fixes #5693
Notes for Reviewers This PR contains minor style fixes for the mobile size of a section on the blog page.
- [x] Yes, I signed my commits.
Outcome
https://github.com/user-attachments/assets/7a54bf61-9a39-476e-8c2d-0953175b801e
🚀 Preview for commit 039d7876a6f12a690b4a42b4b06e0deb5a41f0e9 at: https://66a139ab9b9eab092ebebda6--layer5.netlify.app
Attached a recording of the outcome, let me know if it looks good or if you have any feedback. Also, let me know about the section Related Blogs if it also needs to be responsive as part of this issue.
@AlfiyaSiddique This looks good to me! Can you please confirm that when we reach the related blogs section, it does become responsive once we refresh the page(after reaching the desired responsiveness), right?
@AlfiyaSiddique There's one issue that you can solve as a part of this PR, make sure that "Layer5" starts from the next section, i.e. from below the image and is centered aligned on this page only. Below is a screenshot of the same. Let me know if it makes sense.
@hargunkaur286 correct the Related Blogs does fit in properly after refreshing the page so no change is needed.
Will make the change for the Layer5 Badges Section and ping you.
Thanks for the feedback.
🚀 Preview for commit 3d9b4aeb02b122f4ea3ccee50996b07dce5d49ad at: https://66a51a7c975f4c44be977ae2--layer5.netlify.app
Hey @hargunkaur286!
The fix for the Layer5 Badges section is done. Do let me know if need any other change.
Thank you for the contribution @AlfiyaSiddique This looks good to me!
@AlfiyaSiddique Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.
img.badge-modal{
max-width:95%; // prev 625px;
}
It's a bit too big imo.
@vishalvivekm this issue resolves when we refresh the page, that's why didn't request for it. Is it valid?
@vishalvivekm this issue resolves when we refresh the page, that's why didn't request for it. Is it valid?
:heavy_check_mark: Thank you, just confirmed this on my :iphone:
Is it valid?
Quite not.
🚀 Preview for commit 26b2898a4db58c86f1cecd2b816e2ec01e0dce43 at: https://66a6a29cc499827ed3ad4dcd--layer5.netlify.app
Is it valid?
Quite not.
@vishalvivekm What's quite not valid, can you please describe? Do you want me to change the image width here?
img.badge-modal{
max-width:95%; // prev 625px;
}
The review comments are quite not clear to me so confirming!
@hargunkaur286 we're good to go with this PR right?
@AlfiyaSiddique Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.
🚀 Preview for commit 74d8dfaeaa3909b846b120e2af80a37b2669cc57 at: https://66b9f33ca3dcf17da5b486d0--layer5.netlify.app
LGTM !
@AlfiyaSiddique @hargunkaur286, is there anything more to update, or is this good to go?
@Ashparshp nothing from my side. @hargunkaur286 let me know if any more changes are needed
Thank you @AlfiyaSiddique.
@vishalvivekm, just a gentle reminder to review this PR when you get a chance so it can proceed further. Thanks!
@vishalvivekm @sudhanshutech //
@Ashparshp is this still needed? Have you clarified the fix?
@Ashparshp @sudhanshutech if this PR is not needed should I close it?
Already fixed; closing this pull request.