layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Fix: responsiveness issue#5693

Open AlfiyaSiddique opened this issue 1 year ago • 24 comments

Description

This PR fixes #5693

Notes for Reviewers This PR contains minor style fixes for the mobile size of a section on the blog page.

Signed commits

  • [x] Yes, I signed my commits.

Outcome

https://github.com/user-attachments/assets/7a54bf61-9a39-476e-8c2d-0953175b801e

AlfiyaSiddique avatar Jul 24 '24 17:07 AlfiyaSiddique

🚀 Preview for commit 039d7876a6f12a690b4a42b4b06e0deb5a41f0e9 at: https://66a139ab9b9eab092ebebda6--layer5.netlify.app

l5io avatar Jul 24 '24 17:07 l5io

Attached a recording of the outcome, let me know if it looks good or if you have any feedback. Also, let me know about the section Related Blogs if it also needs to be responsive as part of this issue.

AlfiyaSiddique avatar Jul 24 '24 17:07 AlfiyaSiddique

@AlfiyaSiddique This looks good to me! Can you please confirm that when we reach the related blogs section, it does become responsive once we refresh the page(after reaching the desired responsiveness), right?

hargunkaur286 avatar Jul 24 '24 19:07 hargunkaur286

@AlfiyaSiddique There's one issue that you can solve as a part of this PR, make sure that "Layer5" starts from the next section, i.e. from below the image and is centered aligned on this page only. Below is a screenshot of the same. Let me know if it makes sense. Screenshot 2024-07-25 at 2 55 08 PM

hargunkaur286 avatar Jul 25 '24 09:07 hargunkaur286

@hargunkaur286 correct the Related Blogs does fit in properly after refreshing the page so no change is needed. Will make the change for the Layer5 Badges Section and ping you. Thanks for the feedback.

AlfiyaSiddique avatar Jul 25 '24 14:07 AlfiyaSiddique

🚀 Preview for commit 3d9b4aeb02b122f4ea3ccee50996b07dce5d49ad at: https://66a51a7c975f4c44be977ae2--layer5.netlify.app

l5io avatar Jul 27 '24 16:07 l5io

Hey @hargunkaur286! The fix for the Layer5 Badges section is done. Do let me know if need any other change.

AlfiyaSiddique avatar Jul 27 '24 16:07 AlfiyaSiddique

Thank you for the contribution @AlfiyaSiddique This looks good to me!

hargunkaur286 avatar Jul 27 '24 19:07 hargunkaur286

@AlfiyaSiddique Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

ashparshp avatar Jul 28 '24 17:07 ashparshp

img.badge-modal{
max-width:95%; // prev 625px;
}

It's a bit too big imo. image

vishalvivekm avatar Jul 28 '24 19:07 vishalvivekm

@vishalvivekm this issue resolves when we refresh the page, that's why didn't request for it. Is it valid?

hargunkaur286 avatar Jul 28 '24 19:07 hargunkaur286

@vishalvivekm this issue resolves when we refresh the page, that's why didn't request for it. Is it valid?

:heavy_check_mark: Thank you, just confirmed this on my :iphone:

Is it valid?

Quite not.

vishalvivekm avatar Jul 28 '24 19:07 vishalvivekm

🚀 Preview for commit 26b2898a4db58c86f1cecd2b816e2ec01e0dce43 at: https://66a6a29cc499827ed3ad4dcd--layer5.netlify.app

l5io avatar Jul 28 '24 19:07 l5io

Is it valid?

Quite not.

@vishalvivekm What's quite not valid, can you please describe? Do you want me to change the image width here?

img.badge-modal{
max-width:95%; // prev 625px;
}

The review comments are quite not clear to me so confirming!

AlfiyaSiddique avatar Jul 31 '24 14:07 AlfiyaSiddique

@hargunkaur286 we're good to go with this PR right?

ashparshp avatar Aug 01 '24 06:08 ashparshp

@AlfiyaSiddique Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

ashparshp avatar Aug 03 '24 16:08 ashparshp

🚀 Preview for commit 74d8dfaeaa3909b846b120e2af80a37b2669cc57 at: https://66b9f33ca3dcf17da5b486d0--layer5.netlify.app

l5io avatar Aug 12 '24 11:08 l5io

LGTM !

Muhammed-Moinuddin avatar Aug 14 '24 08:08 Muhammed-Moinuddin

@AlfiyaSiddique @hargunkaur286, is there anything more to update, or is this good to go?

ashparshp avatar Aug 16 '24 06:08 ashparshp

@Ashparshp nothing from my side. @hargunkaur286 let me know if any more changes are needed

AlfiyaSiddique avatar Aug 17 '24 07:08 AlfiyaSiddique

Thank you @AlfiyaSiddique.

ashparshp avatar Aug 17 '24 08:08 ashparshp

@vishalvivekm, just a gentle reminder to review this PR when you get a chance so it can proceed further. Thanks!

AlfiyaSiddique avatar Aug 23 '24 13:08 AlfiyaSiddique

@vishalvivekm @sudhanshutech //

ashparshp avatar Sep 21 '24 18:09 ashparshp

@Ashparshp is this still needed? Have you clarified the fix?

sudhanshutech avatar Oct 09 '24 10:10 sudhanshutech

@Ashparshp @sudhanshutech if this PR is not needed should I close it?

AlfiyaSiddique avatar Nov 10 '24 17:11 AlfiyaSiddique

Already fixed; closing this pull request.

Vidit-Kushwaha avatar Jan 15 '25 20:01 Vidit-Kushwaha