layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

[sistent] Add Error boundary component under sistent project

Open sudhanshutech opened this issue 1 year ago • 13 comments

Current Behavior

We use a custom error boundary component that display a component whenever there is a error in ui.

Desired Behavior

This component can be found under https://github.com/layer5io/sistent/tree/master/src/custom/ErrorBoundary. Add this component under layer5/project/component

Screenshots / Mockups

Implementation

Acceptance Tests


Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

sudhanshutech avatar Jul 11 '24 12:07 sudhanshutech

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Jul 11 '24 12:07 github-actions[bot]

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Jul 11 '24 12:07 github-actions[bot]

@sudhanshutech can i work on this?

aayushdhiman01 avatar Jul 11 '24 14:07 aayushdhiman01

@sudhanshutech can i work on this

Harsh-svg988 avatar Jul 11 '24 18:07 Harsh-svg988

Since we follow the FCFS rule, @aayushdhiman01 Go ahead! I am assigning it to you! @Harsh-svg988 Please have a look at other open issues.

hargunkaur286 avatar Jul 12 '24 18:07 hargunkaur286

Any progress @aayushdhiman01 ?

sudhanshutech avatar Jul 14 '24 13:07 sudhanshutech

Any progress @aayushdhiman01 ?

Working on it.

aayushdhiman01 avatar Jul 14 '24 13:07 aayushdhiman01

@sudhanshutech do i need to add the component in layer5.io/projects/sistent/components??

aayushdhiman01 avatar Jul 15 '24 13:07 aayushdhiman01

yes

sudhanshutech avatar Jul 15 '24 13:07 sudhanshutech

@sudhanshutech image is this fine?? I have to add the description of the error boundary component inside this, like the other components?

aayushdhiman01 avatar Jul 15 '24 15:07 aayushdhiman01

@aayushdhiman01 it will include everything as other components: Overview Guidance Code.

Atleast overview and code tab should be there . In Overview you can you use screenshot but in code section use proper code and display the component.

sudhanshutech avatar Jul 16 '24 11:07 sudhanshutech

@sudhanshutech image so how to show the error boundary component? I tried to create a demo component , which will throw error on clicking a button and trigger error boundary component

aayushdhiman01 avatar Jul 18 '24 16:07 aayushdhiman01

@sudhanshutech #5703 can u check the code, need to add show the component? How to show ?

aayushdhiman01 avatar Jul 20 '24 11:07 aayushdhiman01

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 03:04 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Apr 27 '25 09:04 stale[bot]