layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Add spacing above the heading

Open Muhammed-Moinuddin opened this issue 1 year ago • 17 comments

Current Behavior

Open Source Internship Program heading with it's title needs alignment.

Screenshot from 2024-07-08 04-31-36

Desired Behavior

Heading should have some space on top as well as on bottom (check with headings of other pages like https://layer5.io/projects)

Screenshots / Mockups

Implementation

Acceptance Tests


Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

Muhammed-Moinuddin avatar Jul 07 '24 23:07 Muhammed-Moinuddin

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Jul 08 '24 01:07 github-actions[bot]

This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Jul 08 '24 01:07 github-actions[bot]

@Muhammed-Moinuddin sir can I work on this issue and plz assigned this issue to me

r-kundan avatar Jul 08 '24 07:07 r-kundan

@Muhammed-Moinuddin sir can I work on this issue and plz assigned this issue to me

Thanks for the interest. It is part of our meeting agenda today so will be assigned via meeting by the community. I recommend you to join it. https://layer5.io/community/calendar

Muhammed-Moinuddin avatar Jul 08 '24 09:07 Muhammed-Moinuddin

@Muhammed-Moinuddin sir can I work on this issue and plz assigned this issue to me

r-kundan avatar Jul 08 '24 12:07 r-kundan

Screenshot 2024-07-09 at 11 46 54 AM i changed it plz check it out

r-kundan avatar Jul 11 '24 12:07 r-kundan

Screenshot 2024-07-09 at 11 46 54 AM i changed it plz check it out

Kindly check my comment on your commit.

Muhammed-Moinuddin avatar Jul 11 '24 16:07 Muhammed-Moinuddin

Can you explain to me clearly what you mean? Because as you said I have added space above and below the title

r-kundan avatar Jul 11 '24 17:07 r-kundan

Can you explain to me clearly what you mean? Because as you said I have added space above and below the title

Kindly check that comment, it's pretty detailed. You have done good but we can achieve code consistency with a small thing.

Muhammed-Moinuddin avatar Jul 11 '24 23:07 Muhammed-Moinuddin

@Muhammed-Moinuddin if the issue is still open please assign it to me I would like to solve it

CodeMaverick2 avatar Jul 15 '24 13:07 CodeMaverick2

@Muhammed-Moinuddin if the issue is still open please assign it to me I would like to solve it

Thank you for interest. But it's already assigned and in progress.

Muhammed-Moinuddin avatar Jul 15 '24 13:07 Muhammed-Moinuddin

@Muhammed-Moinuddin Sir, I have updated the PR please check it

r-kundan avatar Jul 15 '24 15:07 r-kundan

@Muhammed-Moinuddin Sir, I have updated the PR please check it

Kindly check my comment. And let's discuss this via slack.

Muhammed-Moinuddin avatar Jul 15 '24 16:07 Muhammed-Moinuddin

Hi @Muhammed-Moinuddin , is this issue still open?

I-karmayogi avatar Jul 29 '24 16:07 I-karmayogi

@Muhammed-Moinuddin @sudhanshutech i would like to solve this issue. Can u please assign me.

fakegithub01 avatar Aug 14 '24 18:08 fakegithub01

Hi @Muhammed-Moinuddin , is this issue still open?

Yes it's open now. Would you like to work on it?

Muhammed-Moinuddin avatar Aug 14 '24 20:08 Muhammed-Moinuddin

I have set it up locally and please assign this issue i will wok on it @Muhammed-Moinuddin @narasimha-1511 @sudhanshutech

fakegithub01 avatar Aug 15 '24 05:08 fakegithub01

@fakegithub01, assigned to you.

ashparshp avatar Aug 31 '24 22:08 ashparshp

I'll complete it.

Muhammed-Moinuddin avatar Sep 07 '24 09:09 Muhammed-Moinuddin

Hi @Muhammed-Moinuddin @sudhanshutech, is this issue still available? If so, I would like to work on it.

I have a possible fix in the following branch: https://github.com/FaatimaAbidi/layer5/tree/fix_for_headers.

FaatimaAbidi avatar Nov 16 '24 06:11 FaatimaAbidi

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 26 '25 02:04 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Apr 27 '25 09:04 stale[bot]

Is the issue open by any chance?

adu-CS avatar Jun 13 '25 18:06 adu-CS