layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard
Published 1 month ago • verified publisher icon layer5io

refactor(5589): image in View state management

Open surajgjadhav opened this issue 1 year ago • 3 comments

Description

This PR fixes #5589

Notes for Reviewers Refactored image in view state handling for css or image toggle

Signed commits

  • [ ] Yes, I signed my commits.

surajgjadhav avatar Jun 22 '24 06:06 surajgjadhav

🚀 Preview for commit 688173f9edf54e0635cd703f803f743d16a69aff at: https://6676d8f683621c96583739db--layer5.netlify.app

l5io avatar Jun 22 '24 14:06 l5io

HI @sudhanshutech , ideally that state should be in useEffect, but as I analyze the code, we are creating new state just to maintain status of inView state and using that in our code. so, instead of adding new state we can directly use inView state in our code. So, I have removed that additional state management code and directly used inView state. Thanks

surajgjadhav avatar Jun 26 '24 15:06 surajgjadhav

@surajgjadhav Thank you for your contribution. Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes.

Deepak0320Singhal avatar Jun 30 '24 15:06 Deepak0320Singhal

@sudhanshutech @vishalvivekm do we need this refactor?

iArchitSharma avatar Jul 05 '24 10:07 iArchitSharma