layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

make integrations column visible in mobile view

Open JayKay24 opened this issue 1 year ago • 15 comments

Description

This PR fixes #5514

Notes for Reviewers Screenshot 2024-06-03 at 15 02 15

Signed commits

  • [x] Yes, I signed my commits.

JayKay24 avatar Jun 03 '24 12:06 JayKay24

🚀 Preview for commit e3fa1f5cd3126352645f3020c1635a1662cf4750 at: https://665db5f9979a3ebb3cb1f169--layer5.netlify.app

l5io avatar Jun 03 '24 12:06 l5io

Thank you, @JayKay24! 😀

leecalcote avatar Jun 03 '24 15:06 leecalcote

Thank you, @sudhanshutech 👏

leecalcote avatar Jun 03 '24 17:06 leecalcote

🚀 Preview for commit cb5f05772a1520fb7f1774e54a93fc647355786c at: https://66606bcdb58c8f1e20bc8c0e--layer5.netlify.app

l5io avatar Jun 05 '24 13:06 l5io

@JayKay24 Notice at the following screen size text and button doesn't show up?

image

iArchitSharma avatar Jun 05 '24 19:06 iArchitSharma

@iArchitSharma Yes, I noticed. It's a problem also present in the production version. I think it should be a separate issue.

JayKay24 avatar Jun 05 '24 19:06 JayKay24

@JayKay24 Also from width 679 to 417 both the container or columns should be aligned equally, just like they are on width 350

image

iArchitSharma avatar Jun 05 '24 19:06 iArchitSharma

@iArchitSharma Yes, I noticed. It's a problem also present in the production version. I think it should be a separate issue.

@iArchitSharma Yes, I noticed. It's a problem also present in the production version. I think it should be a separate issue.

Thanks, please fix it on the same PR, also somewhere around 950 - 960 width the class not-visible changes to visible this logic was written to hide those icons or cards, so it can be removed now

iArchitSharma avatar Jun 05 '24 19:06 iArchitSharma

@JayKay24 Thank you for your contributions. Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes.

vishalvivekm avatar Jun 10 '24 05:06 vishalvivekm

@JayKay24 Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes.

Deepak0320Singhal avatar Jun 16 '24 15:06 Deepak0320Singhal

@Deepak0320Singhal I'm still working on this. Will not make it to the Website's meeting.

JayKay24 avatar Jun 16 '24 20:06 JayKay24

@JayKay24 if you are finding it difficult to move forward with the changes here due to your availability and other commitments, please let us know if we need to consider reassigning the item to some other contributors/

vishalvivekm avatar Jun 17 '24 04:06 vishalvivekm

@vishalvivekm Sure. Lets assign this to someone to implement these changes. I didnt foresee how hectic my schedule would become.

JayKay24 avatar Jun 17 '24 05:06 JayKay24

Hi I can add this into my work on #5581

JonathanKoerber avatar Jun 17 '24 12:06 JonathanKoerber

@JayKay24 what's the progress here?

sudhanshutech avatar Jun 26 '24 09:06 sudhanshutech