layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Animations to a section

Open hargunkaur286 opened this issue 1 year ago • 11 comments

Description

This PR fixes #5344

Notes for Reviewers @sudhanshutech Can you have a look at it? I've added the animations.

Signed commits

  • [x] Yes, I signed my commits.

hargunkaur286 avatar May 30 '24 17:05 hargunkaur286

🚀 Preview for commit 92896efa9932f19378bb534d80e2eef63935e8b8 at: https://6658beba8484c053f0e45c0c--layer5.netlify.app

l5io avatar May 30 '24 18:05 l5io

@hargunkaur286 Let's discuss this on Websites's call on Monday. Adding this as an agenda item into the meeting minutes.

vishalvivekm avatar Jun 02 '24 17:06 vishalvivekm

animation looks good though to me. @leecalcote does this animation looks good to you?

sudhanshutech avatar Jun 03 '24 17:06 sudhanshutech

animation looks good though to me. @leecalcote does this animation looks good to you?

The new animations on the front page look really good, yes. I wonder if we can't add these same animations on the Solutions pages, too.

We have a winner here, @hargunkaur286! 🎈 🎉

leecalcote avatar Jun 03 '24 18:06 leecalcote

🚀 Preview for commit eac28b225ec7d7a90cb5bf67cdc6d00cdaf811d7 at: https://6663acfeca7ec36060edea08--layer5.netlify.app

l5io avatar Jun 08 '24 01:06 l5io

@sudhanshutech Can you have a look now?

hargunkaur286 avatar Jun 08 '24 01:06 hargunkaur286

lets see a last review today website call

sudhanshutech avatar Jun 10 '24 11:06 sudhanshutech

@hargunkaur286 why there is changes in package-lock.json if no change in package.json. If you have reverted any change also ensure you clear the package-lock.json module

sudhanshutech avatar Jun 11 '24 20:06 sudhanshutech

@sudhanshutech Can you have a look now?

hargunkaur286 avatar Jun 19 '24 10:06 hargunkaur286

@sudhanshutech is our vacation this week. @iArchitSharma can help, though.

leecalcote avatar Jun 19 '24 13:06 leecalcote

@hargunkaur286 merge conflicts

sudhanshutech avatar Jun 26 '24 09:06 sudhanshutech

It's duplicate has been merged - https://github.com/layer5io/layer5/pull/5633

iArchitSharma avatar Jul 05 '24 10:07 iArchitSharma