layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

[Sistent] Feat: JSX syntax highlighting on code pages of sistent

Open lakshz opened this issue 1 year ago • 9 comments

Description

This PR fixes #5534

Before

Screenshot 2024-05-12 at 15 20 51

After

  • Light theme Screenshot 2024-05-12 at 15 21 12

  • Dark Theme Screenshot 2024-05-12 at 15 21 49

Notes for Reviewers

Signed commits

  • [x] Yes, I signed my commits.

lakshz avatar May 12 '24 09:05 lakshz

🚀 Preview for commit 38b3d7436e946a3e7d636447ae49c01290342994 at: https://66409464683dc4aea8e762ba--layer5.netlify.app

l5io avatar May 12 '24 10:05 l5io

Hey @lakshz, let's discuss this on today's website meeting at 5:30 PM IST. I am adding this as an agenda item. Please Join https://meet.layer5.io/websites if you are available during the meet.

ritiksaxena124 avatar May 13 '24 06:05 ritiksaxena124

I'm dropping an approving review to this. I wonder if there are any contrary opinions @ritiksaxena124?.. 👀

Rexford74 avatar May 15 '24 13:05 Rexford74

@lakshz can you remove the Sistentthemeprovider wrapped from every component. It should be only mentioned at one place because it is wrapped globally and not on each comps. It can be mentioned at about or its guidance // @Rexford74 @nebula-aac your thoughts?

sudhanshutech avatar May 24 '24 06:05 sudhanshutech

A merge conflict popped up, @lakshz

leecalcote avatar May 29 '24 23:05 leecalcote

Checking back in. Looks like the merge conflict and response to feedback is needed, @lakshz

leecalcote avatar Jun 06 '24 20:06 leecalcote

When I try to commit after resolving merge conflicts, I see the below error: Screenshot 2024-06-07 at 13 38 18

Seems like, eslint dependency has migrated from using .eslintrc files, due to that the pre-commit is failing.

@leecalcote Should I continue with resolving the eslint issue in this PR?

lakshz avatar Jun 07 '24 08:06 lakshz

@lakshz, PRs generally merge faster the smaller that they are....

leecalcote avatar Jun 13 '24 23:06 leecalcote

When I try to commit after resolving merge conflicts, I see the below error: Screenshot 2024-06-07 at 13 38 18

Seems like, eslint dependency has migrated from using .eslintrc files, due to that the pre-commit is failing.

@leecalcote Should I continue with resolving the eslint issue in this PR?

HI @lakshz , This issue is resolved, Could you please take the latest pull and check again?

surajgjadhav avatar Jun 29 '24 07:06 surajgjadhav