layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

CSS style rule updates for issue #5516

Open JonathanKoerber opened this issue 1 year ago • 20 comments

The SistentWrappre page section added margin-top: 15 to extend the container up. The margin-top in h2 and h3 was changed from -7 to 7, bringing text back inside the parent container and aligning the infra-page component with the top section.

JoinCommunityWrapper width 18rem => 25rem to match the current website. g

Description

This PR fixes #5516

Notes for Reviewers

Signed commits

  • [ ] Yes, I signed my commits.

JonathanKoerber avatar May 08 '24 15:05 JonathanKoerber

🚀 Preview for commit 2d2ef1aaf20c9fe68a443b5224211fc89f5e2e89 at: https://663ba19250d9050e48a1cde8--layer5.netlify.app

l5io avatar May 08 '24 16:05 l5io

Thank you, @JonathanKoerber 👏

leecalcote avatar May 10 '24 03:05 leecalcote

Screenshot 2024-05-10 at 10 46 17

When I click "About Sistent", I see the above page. It still doesn't scroll to the heading. The problem might be due to different screen sizes.

lakshz avatar May 10 '24 05:05 lakshz

Hey @JonathanKoerber , let's discuss this on today's website meeting at 12:00 pm GMT / 5:30 PM IST. I am adding this as an agenda item. Please join if you are available during the meet.

ritiksaxena124 avatar May 13 '24 06:05 ritiksaxena124

Thanks for the feedback. I'll take another look at this issue.

JonathanKoerber avatar May 13 '24 20:05 JonathanKoerber

@JonathanKoerber thanks, let us know when you fix this

iArchitSharma avatar May 14 '24 10:05 iArchitSharma

Screencast from 2024-05-20 18-49-34.webm

Can you work on this much unnecessary white space

captain-Akshay avatar May 20 '24 13:05 captain-Akshay

I'll work on the white space issue. Thanks for the feedback.

JonathanKoerber avatar May 20 '24 15:05 JonathanKoerber

🚀 Preview for commit b6d34068121f9eeb4bf653035e66bbded4ec99d1 at: https://664fd71eaf6b27a2792c7a3a--layer5.netlify.app

l5io avatar May 23 '24 23:05 l5io

@JonathanKoerber merge conflicts...

sudhanshutech avatar May 24 '24 06:05 sudhanshutech

Refactor About page to follow pattern of project/sistent/identiy/color. About now uses style from SystenLayout to style and and IntraPage component to generate links on right side from section title id's. Because there is not much content in about page no links will show. See the test link screen shot. image Image with Test link: image Mobile No extra white space: image

JonathanKoerber avatar May 25 '24 22:05 JonathanKoerber

🚀 Preview for commit a9d5b960bed12afe880e20ae92428066642391c3 at: https://6653d4bb4b92a6fe2f91a1a9--layer5.netlify.app

l5io avatar May 27 '24 00:05 l5io

@JonathanKoerber merge conflicts

captain-Akshay avatar May 30 '24 19:05 captain-Akshay

🚀 Preview for commit 3a6497d784ce8ece2a6936feb29a0a85cb14bbcd at: https://665e428fbcfaf8678cf94527--layer5.netlify.app

l5io avatar Jun 03 '24 22:06 l5io

I'm not 100% sure how to fix these merge conflicts. I tried to merge the branch earlier but ended up with a lot of extra commits. This last commit I merge my local branch with upstream/master then merged in the changes then reset origin/fix-position-page-section-navigator. This should only be 1 commit a head of master. If there are merge conflicts please advise how to resolve.

JonathanKoerber avatar Jun 04 '24 15:06 JonathanKoerber

🚀 Preview for commit e288d8cb35d1425790762e847e25da7363e69791 at: https://6669d6e90f92a7031ee6b1eb--layer5.netlify.app

l5io avatar Jun 12 '24 17:06 l5io

Any Ideas how to solve this issue? image

JonathanKoerber avatar Jun 13 '24 16:06 JonathanKoerber

🚀 Preview for commit 367495c0ec9a917c7bd472a3714f9302a8f0c898 at: https://666b460884039e94ed444e10--layer5.netlify.app

l5io avatar Jun 13 '24 19:06 l5io

🚀 Preview for commit a7a9180aed3e56268f1ec81085a3ddf940c19661 at: https://666b625b4db7a162428551e8--layer5.netlify.app

l5io avatar Jun 13 '24 21:06 l5io

🚀 Preview for commit cdf5cd605fac36984cecab9de40af065d01e18ef at: https://666b6d4b84039ec1cb444db3--layer5.netlify.app

l5io avatar Jun 13 '24 22:06 l5io

@JonathanKoerber are you still working on this?

sudhanshutech avatar Aug 14 '24 07:08 sudhanshutech