layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

In devices width<1100 links of the verticle navbar are not behaving as expected

Open Manishch27 opened this issue 1 year ago β€’ 9 comments

Description

In small devices width<1100px in the verticle navBar when we click on any link it covers the whole list and a blue layer is there on the whole content.

Expected Behavior

Only the content should be clickable and also there should not be any blue layer on the content.

Screenshots

https://github.com/layer5io/layer5/assets/98028450/ae6b6ea1-0da9-46e7-a271-0e037ab6ea8f

Environment:

  • Host OS: Android
  • Browser: Chrome

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

Manishch27 avatar Feb 11 '24 21:02 Manishch27

I would like to work on this issue.

Manishch27 avatar Feb 11 '24 21:02 Manishch27

Thanks for flagging. It might be a design choice rather than a bug. Appreciate your feedback, @saurabh100ni. Right?

ashparshp avatar Feb 12 '24 14:02 ashparshp

I feel it is not a bug but when ever you build a website and use it in your phone, it is a native style The Browser provides there's a css class to remove it

A single line and it will be fixed.

myselfprincee avatar Feb 13 '24 05:02 myselfprincee

@myselfprincee But it provides better feedback to the user whenever get clicked..

ashparshp avatar Feb 13 '24 05:02 ashparshp

@myselfprincee But it provides better feedback to the user whenever get clicked..

Yes for sure

myselfprincee avatar Feb 13 '24 05:02 myselfprincee

@saurabh100ni, it seems this issue may not be valid. Can we close it?

ashparshp avatar Feb 13 '24 05:02 ashparshp

@Manishch27, thanks for raising this concern. I fail to see where there's a blue layer. Could you help me understand the issue that you're describing a bit more? At the moment, it's not clear that there's sufficient evidence to warrant action here (that the behavior shown in the screen recording is a bug).

leecalcote avatar Feb 14 '24 06:02 leecalcote

@Manishch27, thanks for raising this concern. I fail to see where there's a blue layer. Could you help me understand the issue that you're describing a bit more? At the moment, it's not clear that there's sufficient evidence to warrant action here (that the behavior shown in the screen recording is a bug).

@Manishch27 thoughts??

vishalvivekm avatar Feb 22 '24 17:02 vishalvivekm

@leecalcote I agree with @myselfprincee and @Ashparshp it's not a bug it's a design choice and I apologize for the wrong label, but I don't find any label related to the design. When we open the layer5 website on the phone and click on any of the navigation links from the verticle navBar a blue layer appears on the top of the clicked link for a faction of seconds, it's a default styling provided by the browser for the links, but we can correct it with the help of CSS for the better user interface. @leecalcote attachment helps you to understand the issue better with current behavior and expected behavior.

https://github.com/layer5io/layer5/assets/98028450/d461e029-1a76-4eed-878f-a2bc1050f756

Manishch27 avatar Feb 23 '24 19:02 Manishch27

If this isn't considered an issue, shall we close it? @vishalvivekm @Manishch27

ashparshp avatar May 14 '24 17:05 ashparshp

I think we should

myselfprincee avatar May 14 '24 17:05 myselfprincee

Thanks, @myselfprincee. Closing this issue as it's deemed invalid.

ashparshp avatar May 14 '24 17:05 ashparshp