layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

improve smoothness of scroll-to-top transition issue #5243

Open ashparshp opened this issue 2 years ago • 11 comments

Description I changed the constant value from 16 to 8 in the formula const translateY = scrollPosition / 8;. This modification seems to have significantly improved the smoothness and reduced lag.

This PR fixes # Remove delay / improve smoothness of scroll-to-top transition https://github.com/layer5io/layer5/issues/5243

Notes for Reviewers Video.webm

Signed commits

  • [x] Yes, I signed my commits.

ashparshp avatar Jan 02 '24 20:01 ashparshp

🚀 Preview for commit ffbb0cce28bfc3d152ca55d23e57f45427441a14 at: https://6594749a7a8e950ca4fd7f8a--layer5.netlify.app

l5io avatar Jan 02 '24 20:01 l5io

🚀 Preview for commit d6c28a4bc34dae691ee78f77225fbf67c90fbf47 at: https://659517ccb0759372e382f9c0--layer5.netlify.app

l5io avatar Jan 03 '24 08:01 l5io

Thanks @Ashparshp , works smoothly on Chrome and firefox @leecalcote do you still see this issue on safari?

iArchitSharma avatar Jan 03 '24 08:01 iArchitSharma

Yes, I do see the same issue in Safari still. I believe the issue is in part caused by the top banner bar. I try to capture this in the recording, which demonstrates a glitch when the top banner comes into play.

https://github.com/layer5io/layer5/assets/7570704/46ad0bf1-358e-4c31-8485-f89dc9d31fa3

leecalcote avatar Jan 03 '24 08:01 leecalcote

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Jan 20 '24 09:01 github-actions[bot]

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Jan 20 '24 09:01 github-actions[bot]

@Ashparshp Let us know If you are still working on this, if not, then we can open this for new contributors.

saurabh100ni avatar Jan 20 '24 09:01 saurabh100ni

Hi @saurabh100ni , I'm currently unable to address the issue in Safari as I don't have access to it. Please feel free to unassign me, and if someone with Safari access is available, they can take over. Thanks!

ashparshp avatar Jan 20 '24 11:01 ashparshp

i have access to safari i will take over from here

narasimha-1511 avatar Jan 20 '24 13:01 narasimha-1511

@narasimha-1511, could you kindly request @saurabh100ni to assign you to this task before you begin working on it? Thanks!

ashparshp avatar Jan 20 '24 13:01 ashparshp

@saurabh100ni can you please assign me this issue..

narasimha-1511 avatar Jan 20 '24 13:01 narasimha-1511

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Mar 17 '24 14:03 stale[bot]

As the animation for the hero image has been changed, I am closing this PR

iArchitSharma avatar Mar 29 '24 10:03 iArchitSharma