layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Much spaces between contribution and General contribution flow

Open AbiodunVlad opened this issue 1 year ago • 14 comments

Description Much spaces between contribution and General contribution flow #4636

This PR fixes #4636

Notes for Reviewers Kindly find the changes made on all page under the Handbook section.

Signed commits

  • [x] Yes, I signed my commits.

AbiodunVlad avatar Nov 22 '23 15:11 AbiodunVlad

🚀 Preview for commit 9c01e48b643231bd77c2bc2e3cadb7923a7b5605 at: https://655e287b036f1f4736c2ee14--layer5.netlify.app

l5io avatar Nov 22 '23 16:11 l5io

There is a failed check here because of the Node version. I don't have permission to edit it. Please assist.

AbiodunVlad avatar Nov 22 '23 16:11 AbiodunVlad

@ritiksaxena124 @Mohith234 @abhijeetgauravm There is a NODE version problem here. The version is 19 but I don't have permission to edit it to a less one. Please help fix it.

AbiodunVlad avatar Nov 22 '23 17:11 AbiodunVlad

@AbiodunVlad Use Node Version Manager (NVM) to downgrade your node version.

Mohith234 avatar Nov 23 '23 17:11 Mohith234

PR title needs renamed.

leecalcote avatar Nov 24 '23 14:11 leecalcote

🚀 Preview for commit c0a96fdf3c86adf4ce713e732d3a1bcf8ad1546a at: https://6561374cc9c6ba3f06804115--layer5.netlify.app

l5io avatar Nov 24 '23 23:11 l5io

All checks have finally passed! PR is good to go.

@abhijeetgauravm @Mohith234 @leecalcote

AbiodunVlad avatar Nov 25 '23 00:11 AbiodunVlad

Hey @AbiodunVlad Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.

abhijeetgauravm avatar Nov 26 '23 06:11 abhijeetgauravm

🚀 Preview for commit 883fb49d44e1f837fdbe04e71f7c5ed7cf5ebb9b at: https://6564ca7e1a6803007a883a5a--layer5.netlify.app

l5io avatar Nov 27 '23 16:11 l5io

I reviewed the code and fixed necessary changes.

AbiodunVlad avatar Nov 27 '23 17:11 AbiodunVlad

@abhijeetgauravm Thank you for your feedback. What unnecessary changes do you observe? Is it good to merge or do I have to fix something?

AbiodunVlad avatar Nov 29 '23 18:11 AbiodunVlad

Merge conflicts....

leecalcote avatar Nov 29 '23 23:11 leecalcote

🚀 Preview for commit f99b70c8b0bfacc06a5725c57bcfa7794de118b6 at: https://656dd082102980592a346bdc--layer5.netlify.app

l5io avatar Dec 04 '23 13:12 l5io

Conflicts resolved. @leecalcote

AbiodunVlad avatar Dec 04 '23 14:12 AbiodunVlad