layer5
layer5 copied to clipboard
layer5io
[Fix]Inter-page navigation
Description
This PR fixes #5068 Inter-page navigation on all pages of the Handbook has been smoothed out from abrupt behavior. Notes for Reviewers
Old behaviour
https://github.com/layer5io/layer5/assets/93874580/4d2f0af4-7572-445a-8eb4-827728a23ce8
New behaviour
https://github.com/layer5io/layer5/assets/93874580/483f7cdd-1987-47db-a0f4-3e44857dad73
- [ ] Yes, I signed my commits.
🚀 Preview for commit 790e9ccb16c38ae30d5353e8530d9a5ebc058c4d at: https://653643364c06bc266cb35c7d--layer5.netlify.app
Hey @ankushbhardwaj408 Let's discuss this on website call today at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.
@vishalvivekm @abhijeetgauravm I missed the meeting because I was out. Apologies. Please review my PR. appreciate your help.
@ankushbhardwaj408 the transition not looking as smooth, you can see meshery docs how smooth that it is. Apply styling to get it smoother
@sudhanshutech Can you tell me where I can find the docs.meshery.io code base so that I can take a look at it and implement the work here.
@sudhanshutech Can you tell me where I can find the docs.meshery.io code base so that I can take a look at it and implement the work here.
no i am just referring you to the behaviour not the approach because docs is in other language
🚀 Preview for commit 0e8a7b86a7ca56f9519528e978664805d4053b3a at: https://653cca232de5725ffbe6eeb7--layer5.netlify.app
Hey @ankushbhardwaj408 Let's discuss this on website call tomorrow at 5:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.
Description
This PR fixes #5068 Inter-page navigation on all pages of the Handbook has been smoothed out from abrupt behavior. Notes for Reviewers
Old behaviour
old.mp4 New behaviour
new.mp4 Signed commits
- [ ] Yes, I signed my commits.
Hi @sandramsc i am not able to replicate the beahviour. Some help would be appreciated. But I think it fixes the irregularity as shown in the video.
The main issue was in the id names given to the elements because some links do not have transition effects so I corrected the id names and now all have the same behavior.
🚀 Preview for commit dc4efc7b741ff6df8bb68fd9df2508c464fa9b8c at: https://6546144662a9b26575df61a5--layer5.netlify.app
@sudhanshutech I thought we were talking about links as if some links are behaving differently than others. But I understand your point. I will look into it.
Hey @ankushbhardwaj408 Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.
🚀 Preview for commit 1f6d90ba8ed169d933694705195efd96abfe21e5 at: https://654b77bf7671831340086d6f--layer5.netlify.app
@sudhanshutech I tried to make scroll like meshery docs site but it is not working, I tried to use scroll smooth behavior but still it is not working.
I think we are not getting here what we needed, @ankushbhardwaj408 i will recommend you to discuss this any website meet to get help
Hey @ankushbhardwaj408 Let's discuss this on website call tomorrow at 6:30 PM IST / 7 AM Central time. Please add this as an agenda item in the meeting minutes.
I think we are not getting here what we needed, @ankushbhardwaj408 i will recommend you to discuss this any website meet to get help
Good call, @sudhanshutech
is this a expected behaviour ????? as shown here
https://github.com/layer5io/layer5/assets/111847375/3e2d52a8-3fba-45f1-b6a7-b8d4bc55ec06
@balagowda I think you have the possible solution for it. If you don't mind can you please tell me how you fix it. Appreciate your help.
I think it would be better to solve both the issues in one PR, so I have raised one #5123 , please take a look
@balagowda Thanks for your contribution! but i am already working on this issue. Before creating a pull request, could you please get assigned to the issue to avoid duplication of efforts? Appreciate your understanding. https://github.com/layer5io/layer5/issues?q=is%3Aissue+is%3Aopen+no%3Aassignee Feel free to check these out and comment to get assigned.
Thank you, however my PR does also includes the solution for #5119, please do consider that as well!
Thank you, however my PR does also includes the solution for #5119, please do consider that as well!
Hi @balagowda please take note of what @ankushbhardwaj408 mentioned about issue assignment. The issue this PR attempts to resolve has already been assigned to someone who asked first. And in line with our contribution guidelines I urge you to consider taking a look at other open issues after reading our Contribution guidelines specifically the section "Finding an issue to work on".
It's great you are enthusiastic about contributing, however, to avoid potential confusion and disappointment, it is recommended to first read the contributing guidelines before attempting to create a solution and PR to avoid your efforts going to waste as a result.
If you are interested in helping the assigned contributor to resolve the issue, I suggest starting a thread on Slack and communicating towards a possible solution on there.
🚀 Preview for commit 46ddeded0ba7b30cf8dd849f5b87f61cc2c9bf37 at: https://655379e39d19d2068d8ef421--layer5.netlify.app
🚀 Preview for commit 5cc4e9c6b2f83d1e73b951a6f7432f9a2c55626c at: https://655380a0f2ce64083a09653b--layer5.netlify.app
🚀 Preview for commit 060b974bc5c534f672538af6ca19d655615acf21 at: https://6555966c43d1113335045f56--layer5.netlify.app
🚀 Preview for commit e8cc4d551e853d87a833a2ecee4e7845eefe91ee at: https://65576e8b260bab286118587a--layer5.netlify.app
🚀 Preview for commit c53518ff1b980766504c631f49b59a265df86ae6 at: https://655a32ad34e0764ce02c6d3e--layer5.netlify.app