layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Removed duplicated pattern

Open Nawaz027 opened this issue 2 years ago • 6 comments

Signed-off-by: Nawaz027 [email protected]

Description removed one of the duplicated filters on patterns page from area I section. Link of the webpage: https://layer5.io/learn/service-mesh-books/service-mesh-patterns

This PR fixes https://github.com/layer5io/layer5/issues/3151

This PR fixes #3151

Notes for Reviewers

Signed commits

  • [x] Yes, I signed my commits.

Nawaz027 avatar Sep 08 '22 05:09 Nawaz027

🚀 Preview for commit c7318899b0e588062ed693cb8482f9d0fe8c3594 at: https://63198f5e1a0850413efc040e--layer5.netlify.app

l5io avatar Sep 08 '22 06:09 l5io

Sorry, I accidently removed table data. Now it's being fixed. Also category column is being removed and service mesh pattern is visible now.

Nawaz027 avatar Sep 15 '22 04:09 Nawaz027

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check above.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Sep 15 '22 17:09 github-actions[bot]

@Nawaz027 please do fix the dco issue.

kamalbuilds avatar Sep 15 '22 17:09 kamalbuilds

Creating new deployment preview...

leecalcote avatar Sep 21 '22 22:09 leecalcote

🚀 Preview for commit 430d04fa7850e153017d03561603f37f585155ba at: https://632b986d2cf1860595a9f1fc--layer5.netlify.app

l5io avatar Sep 21 '22 23:09 l5io

I still don't get where is this text duplicated, can you please point me to it? 🤔

Nikhil-Ladha avatar Sep 29 '22 14:09 Nikhil-Ladha

hi @Nikhil-Ladha text isnt duplicated , please see the filters here https://github.com/layer5io/layer5/pull/3160#pullrequestreview-1100703670

kamalbuilds avatar Sep 29 '22 15:09 kamalbuilds

Ok, I see. Perhaps a better issue description is needed...

Nikhil-Ladha avatar Sep 29 '22 15:09 Nikhil-Ladha

Ok, I see. Perhaps a better issue description is needed...

updated

kamalbuilds avatar Sep 29 '22 15:09 kamalbuilds

@Nawaz027 will you discuss this on the websites call today?

debo19 avatar Oct 10 '22 08:10 debo19

@Nawaz027 any updates here?

Nikhil-Ladha avatar Oct 11 '22 11:10 Nikhil-Ladha

Other than DCO, is there do you approve, @legendarykamal?

leecalcote avatar Oct 18 '22 21:10 leecalcote

Thanks for jumping and helping, @Nawaz027. Much appreciated.

There does not seem to be a duplication of patterns, which leaves me wondering what is being fixed here. It seems that we are deleting a valid pattern in this PR.

leecalcote avatar Oct 31 '22 15:10 leecalcote

@Nawaz027 or @legendarykamal will you take a moment to confirm, please?

leecalcote avatar Oct 31 '22 15:10 leecalcote