layer5
layer5 copied to clipboard
Removed duplicated pattern
Signed-off-by: Nawaz027 [email protected]
Description removed one of the duplicated filters on patterns page from area I section. Link of the webpage: https://layer5.io/learn/service-mesh-books/service-mesh-patterns
This PR fixes https://github.com/layer5io/layer5/issues/3151
This PR fixes #3151
Notes for Reviewers
- [x] Yes, I signed my commits.
🚀 Preview for commit c7318899b0e588062ed693cb8482f9d0fe8c3594 at: https://63198f5e1a0850413efc040e--layer5.netlify.app
Sorry, I accidently removed table data. Now it's being fixed. Also category column is being removed and service mesh pattern is visible now.
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).
To amend the commits in this PR with your signoff using the instructions provided in the DCO check above.
To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:
@Nawaz027 please do fix the dco issue.
Creating new deployment preview...
🚀 Preview for commit 430d04fa7850e153017d03561603f37f585155ba at: https://632b986d2cf1860595a9f1fc--layer5.netlify.app
I still don't get where is this text duplicated, can you please point me to it? 🤔
hi @Nikhil-Ladha text isnt duplicated , please see the filters here https://github.com/layer5io/layer5/pull/3160#pullrequestreview-1100703670
Ok, I see. Perhaps a better issue description is needed...
Ok, I see. Perhaps a better issue description is needed...
updated
@Nawaz027 will you discuss this on the websites call today?
@Nawaz027 any updates here?
Other than DCO, is there do you approve, @legendarykamal?
Thanks for jumping and helping, @Nawaz027. Much appreciated.
There does not seem to be a duplication of patterns, which leaves me wondering what is being fixed here. It seems that we are deleting a valid pattern in this PR.
@Nawaz027 or @legendarykamal will you take a moment to confirm, please?