layer5
layer5 copied to clipboard
layer5io
Partners name gets cropped on bigger screen
Current Behavior
RedHat and Vmware's name gets cropped on the bigger screen.
Desired Behavior
Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.
- 📚 See contributing instructions
- 🎨 Wireframes and designs for Layer5 site in Figma.
- 🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack
Thank you for filing this issue, however, this is actually by design as we're not trying to list all partners, users, customers and so the effect is just that of cutting off the list at some point. We need to add more logos in order to have that sense conveyed in the two row view. That's what we should focus on in this issue. To start, let's add Docker's logo and F5's logo.
Thank you for filing this issue, however, this is actually by design as we're not trying to list all partners, users, customers and so the effect is just that of cutting off the list at some point. We need to add more logos in order to have that sense conveyed in the two row view. That's what we should focus on in this issue. To start, let's add Docker's logo and F5's logo.
Okay, I get it. So, just to clarify I have to add Docker and F5's logo in the partner section right?
Hey @Shubhcs01 ! I am new to the community and want to work on this issue. Can you please assign it to me?
Thanks for raising your hand, @tinniaru3005. 👍 Please note that the requirement has shifted.
Thanks for raising your hand, @tinniaru3005. 👍 Please note that the requirement has shifted.
Hello @leecalcote . Thanks for assigning the issue to me. Can you please explain to me the current requirements? I also wanted to confirm if the changes are required on this page.
@tinniaru3005, not quite. Thanks for jumping in. The page that you’re referring to is the project page. The page in question is the homepage. Two new logos are requested. They must be SVGs and grayscaled.
Hey @Shubhcs01 ! I am new to the community and want to work on this issue. Can you please assign it to me?
Hi @tinniaru3005 , first of all welcome to the community 🤝. I am slight busy in some college works so yeah please go on and solve the issue. Also if you need any help just drop a comment. Thanks @leecalcote for explaining the issue.🙂
Hello @Nikhil-Ladha and @leecalcote, If no one is working on the Issue can You assign the issue to me? I m new to the community
Yes, @SaiRev0 you can work on this. Though, the requirement is slightly different as mentioned in this comment
@Nikhil-Ladha can you preferably update the issue title and desc as per this comment https://github.com/layer5io/layer5/issues/3133#issuecomment-1233191687 so that there's no confusion.
(I am not able to edit it)
@Nikhil-Ladha So I have to add 1 more row for the logos of the partners??
am I correct with that??
Yes, and probably move a couple of them in the above row, to the new one.
Yes, and probably move a couple of them in the above row, to the new one.
Hello @Nikhil-Ladha, I have a suggestion. Can he add a sliding effect instead of diving it between two rows? This will look good, I think. If I can contribute, then please let me know.
Nope, the overflow is by design and intentional
Ok, thanks. But if the issue exists, then my setup is ready
@SaiRev0 ask in a public slack channel like #websites channel by tagging appropriate person to whom you would like to ask.
@Nikhil-Ladha please provide the photos and details of all the collaborating companies so that I can add them
For the logo, you could download them from their respective sites docker.com and f5.com
@Nikhil-Ladha So I have to add only 2 more logos.
So I will add them and shift some from the top so both the rows will have the same numbers
Can we chat some else the comments will go long 😅
@SaiRev0, it's looking good to me... so long as you're allowing the logos full span of the page (even to the extent that they get cutoff (that's fine).
The significant size difference between the circular Citrix and the circular F5 logos.... hmm. All should be allowed the same space, which means that two circular logos should essentially be of the same size. Cut out any extra padding in the F5 SVG, if needed.
@SaiRev0, it's looking good to me... so long as you're allowing the logos to full span of the page (even to the extent that they get cut off (that's fine).
Ok I will try and adjust the 6 logos to take the full-screen size
And about the logo size I will fix the f5 logo
@SaiRev0 thanks... although, there should need to be a change to the existing logos, I don't believe.
@SaiRev0 thanks... although, there should need to be a change to the existing logos, I don't believe.
So do I have to change some logos (old logos) or leave it as it is?