layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

[Performance] Image Optimization <img> to <StaticImages> in the Meshery page

Open YashKamboj opened this issue 2 years ago • 13 comments

Current Behavior

The .png and .jpg images cause a lot of performance issues Desired Situation

Change to for image optimization in the handbook section. eg https://github.com/layer5io/layer5/pull/2597 StaticImagePlugin

[Optional] Alternatives

[Optional] Additional context


Contributor Resources

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

YashKamboj avatar Aug 03 '22 14:08 YashKamboj

Hi, I would also like to help with this

Pavel-2004 avatar Aug 08 '22 20:08 Pavel-2004

@Pavel-2004 Go Ahead!!

YashKamboj avatar Aug 08 '22 21:08 YashKamboj

@Pavel-2004 Update on the issue?, do you need any help with this issue?

YashKamboj avatar Aug 15 '22 12:08 YashKamboj

Hi @YashKamboj, I would like to give it a try if @Pavel-2004 no longer wants too.

Jonathan-Foo avatar Aug 16 '22 09:08 Jonathan-Foo

Hi @YashKamboj any updates?

Jonathan-Foo avatar Aug 19 '22 01:08 Jonathan-Foo

Hi @YashKamboj if no one is working on this issue then can you please assign this issue to me.

deveshXm avatar Aug 30 '22 22:08 deveshXm

@Jonathan-Foo’s comment must have been missed accidentally. Congrats on your graduation from frrecodecamp, @Jonathan-Foo 👍

leecalcote avatar Aug 30 '22 22:08 leecalcote

That's all good, and thank you @leecalcote

Jonathan-Foo avatar Aug 31 '22 03:08 Jonathan-Foo

i wanted to ask that do i need to replace the img with staticImages for all the components in "src/sections/Meshery". Also am i at the right Meshery folder. Just wanted to confirm this.

deveshXm avatar Aug 31 '22 05:08 deveshXm

Hi @deveshXm, Yes you have to replace img elements you find with Gatsby's StaticImage component, but don't do it if the image source is an .svg, because it will lower the quality. Yep, you are in the right folder.

Jonathan-Foo avatar Aug 31 '22 05:08 Jonathan-Foo

@Jonathan-Foo I checked out your PR on issue #3014 and i saw that you used constants or props for in eg: src={label1} for staticImages . However , after i pasted the whole url of image it was working perfectly fine. And also the staticImages were not working for GIFs so i am not changing their tags.

deveshXm avatar Aug 31 '22 18:08 deveshXm

I would like to git it a try for this issue?

siddheshJungade avatar Sep 16 '22 17:09 siddheshJungade

@siddheshJungade i am already working on it

deveshXm avatar Sep 16 '22 17:09 deveshXm

Assign me

toukirkhan avatar Oct 11 '22 17:10 toukirkhan

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 16 '22 05:12 stale[bot]

hey @leecalcote I can work on this :smile:

avikt18 avatar Jan 04 '23 15:01 avikt18

@leecalcote kindly review the PR :smile:

avikt18 avatar Jan 11 '23 14:01 avikt18

@avikt18, I'll entrust my review to @GaganpreetKaurKalsi.

leecalcote avatar Jan 11 '23 19:01 leecalcote