layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Added Accessibility in Navbar Component

Open Palaksharma23 opened this issue 3 years ago • 9 comments

Description

This PR fixes #2739

I have added keyboard accessibility to the Navbar

https://user-images.githubusercontent.com/87171452/179660289-3ce7ea8f-376c-41a4-bd76-0ba155595c04.mp4

Notes for Reviewers

Signed commits

  • [✔ ] Yes, I signed my commits.

Palaksharma23 avatar Jul 19 '22 03:07 Palaksharma23

@leecalcote @adithyaakrishna please once review this pull request.

Palaksharma23 avatar Jul 19 '22 03:07 Palaksharma23

🚀 Preview for commit 73475bbeee6262fe44a4ba7fd421d41df3e3f501 at: https://62d638df9107c341c60933fa--layer5.netlify.app

l5io avatar Jul 19 '22 04:07 l5io

@Palaksharma23 Thank you for working on this, do you mind fixing up the DCO? You can refer the deets here, https://github.com/layer5io/layer5/pull/2976/checks?check_run_id=7402090466

adithyaakrishna avatar Jul 19 '22 08:07 adithyaakrishna

Done! @adithyaakrishna :)

Palaksharma23 avatar Jul 19 '22 13:07 Palaksharma23

🚀 Preview for commit 6e1231a251376648912a28b623f233d4162a2e5d at: https://62d8040063025a56df460c2b--layer5.netlify.app

l5io avatar Jul 20 '22 13:07 l5io

@Palaksharma23 Any updates on this PR? 👀

adithyaakrishna avatar Aug 02 '22 09:08 adithyaakrishna

@Palaksharma23... I can't quite say that this is really an issue that we're looking to solve. Likely, this will take a conversation. Are you able to join the next Websites call on Monday to discuss?

leecalcote avatar Aug 03 '22 04:08 leecalcote

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 20 '22 17:09 stale[bot]

Checking in... it has been awhile since we've heard from you on this issue. Are you still working on it? Please let us know and please don't hesitate to contact a MeshMate or any other community member for assistance.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Sep 20 '22 18:09 github-actions[bot]