TwitchDownloader icon indicating copy to clipboard operation
TwitchDownloader copied to clipboard

Kick support

Open lay295 opened this issue 10 months ago • 7 comments

Work in progress... just wanted the Github Actions builds mainly

EDIT: Apparently I don't know how GitHub actions work since I expected this to build. Probably have to resolve the conflicts I guess

lay295 avatar Sep 26 '23 23:09 lay295

It took several days, but I merged master with kick-support for you and also fixed a few bugs while I was there.

  • #880

ScrubN avatar Nov 02 '23 01:11 ScrubN

Also I tested the basic Twitch & Kick functionalities and as far as I can tell everything works as expected.

ScrubN avatar Nov 02 '23 01:11 ScrubN

I'm confused why there's still merge conflicts.

Edit: That was pretty annoying, but thankfully I figured it out 🎉

ScrubN avatar Nov 15 '23 22:11 ScrubN

I got a little tired of manually parsing M3U8s everywhere so I made a dedicated parser, hope you don't mind.

ScrubN avatar Nov 18 '23 19:11 ScrubN

So we can't download the .ts files with an HttpClient anymore, we need to use curl :/

ScrubN avatar Jan 21 '24 03:01 ScrubN

Also annoying issue, this target runs on build but not publish. https://github.com/lay295/TwitchDownloader/blob/dc5cc89ae6001d5543dd5f49304a4930a8f892cf/TwitchDownloaderWPF/TwitchDownloaderWPF.csproj#L126-L128

ScrubN avatar Jan 21 '24 03:01 ScrubN

Could you give a rough estimate as to when we can expect the Kick support? Really appreciate the work you put in btw.

Senterrr avatar Jan 30 '24 18:01 Senterrr