mida icon indicating copy to clipboard operation
mida copied to clipboard

Fix cli https error

Open jonblack opened this issue 8 years ago • 0 comments

This is related to #20.

The command line tool for mida doesn't correctly parse https urls, resulting in the failure to create an absolute url for images. This pr fixes the issue with the cli tool.

In issue #20 I had the same problem because I didn't pass a page url to Document.new, and no error is raised. Instead, Itemprop.make_absolute_url just returns an empty string.

That's by design, but it was certainly hard for me to track down, so I've updated the comment for Document.new.

jonblack avatar Apr 21 '17 13:04 jonblack