Implementation of geom_hist in circular layout

[almeidasilvaf]

Hi, there.

I was trying to plot the gene density per chromosome along with the positions for some SNPs. However, as mentioned in a previous issue ( #82 ), geom="hist" has not been implemented yet. In the source code, there is this code chunk:

if(geom == "hist"){
    stop("geom(hist) is not implemented yet")
  }

The previous issue mentioning this problem was created in 2016. That is a very long time ago. Shouldn't it have been implemented already? Besides, if something is not implemented in a package, why would someone say it is an option in the function's docs?

If the developers don't plan to implement this functionality in a near future, I would suggest at least removing it from the function's docs.

[sanchit-saini]

Hi @almeidasilvaf, Currently, the package is in the process of being rewritten. It is expected to be completed in the coming few months. We will look into it and either implement it or remove it entirely.

[almeidasilvaf]

Thank you for your response, @sanchit-saini

I'm looking forward to seeing this implemented. It doesn't seem difficult. I could try and open a new pull request, but I would have to spend some time to learn the structure of the class to write an appropriate method. As you are familiar with the object class, it will be certainly easier for you.

[sanchit-saini]

Sure, I've added this feature request to the TODO. Probably it will get implemented in the coming weeks.