CustomOreGen icon indicating copy to clipboard operation
CustomOreGen copied to clipboard

No Metallurgy Ore Generation in BOP Nether

Open theJ8910 opened this issue 8 years ago • 2 comments

The title pretty much explains it. Metallurgy ores do not spawn in the Nether when Biomes O' Plenty is installed. This seems to be due to this line in the Metallurgy 4 config file.

Biomes O' Plenty uses a custom chunk provider, biomesoplenty.common.world.ChunkProviderBOPHell. It seems CustomOreGen doesn't recognize this chunk provider as being equivalent to ChunkProviderHell based on this source file.

I haven't taken a look at the other config files, but if they detect the nether in a similar fashion this bug probably affects those mods as well.

I'm using a version of CustomOreGen 1.2.24-101 for Minecraft 1.7.10 with minor tweaks if this matters (nothing that would cause this particular problem, though).

Edit: I should clarify: Even though you use instanceof in your code to include descendants of ChunkProviderHell, this doesn't work with Biomes O' Plenty's ChunkProviderBOPHell because it doesn't inherit from that class.

theJ8910 avatar Feb 20 '17 16:02 theJ8910

Didn't realize this was an issue in 1.7.10. In 1.10, we can just use the dimension type instead of class names, see #177. One of the complications is that the configurations are automatically generated using the Sprocket tool, so it would require modification and re-running of Sprocket to fix this.

lawremi avatar Feb 20 '17 17:02 lawremi

If you're looking for a quick-and-dirty fix in the meantime, I wrote in a hack to my local version of CustomOreGen that fixes this. Here's the gist if you want to take a look.

The relevant changes are on lines 47, 350-366, and 415.

theJ8910 avatar Feb 20 '17 18:02 theJ8910