react-native-picker-select icon indicating copy to clipboard operation
react-native-picker-select copied to clipboard

Published 20 hours ago • verified publisher icon lawnstarter

Add support for iOS dark mode

Open sarcadass opened this issue 3 years ago • 15 comments

I added a new prop darkTheme to have a dark theme on the picker (only on iOS). I used the same color as the native iOS picker in dark system theme when you open a <select> on the web. I wrote a test with the feature.

Preview

Picture

dark-theme-ios

Video

https://user-images.githubusercontent.com/2452603/138324017-8165abd9-2841-4653-8636-5b847eebc8cf.mp4

Test the feature

  1. Download the codeSandbox repo. I could not make a snack because I use the Appearance API of react-native in the example. To use Appearance, you need to edit the App.json if you use expo, a thing you can't do in a snack. I provided the App.json file in the codeSandbox repo.
  2. npm i && expo start
  3. Open the App with expo and open the picker, change your system theme on iOS then switch back to the App and open the picker again.

Related issue

#245

sarcadass avatar Oct 21 '21 18:10 sarcadass

Thank you! This would be such a big win for our team.

cvburgess avatar Oct 27 '21 17:10 cvburgess

@lfkwtz is there anything i can do to help get this merged in?

cvburgess avatar Nov 16 '21 13:11 cvburgess

I just made a fix to apply the proper custom styles for the light & dark themes.

sarcadass avatar Nov 18 '21 15:11 sarcadass

@lfkwtz is there anything i can do to help get this merged in?

You guys have any update on this PR? This would be a really important one for me and the project I'm working on 😊️

luizaugustoventura avatar Nov 27 '21 18:11 luizaugustoventura

@lawnstarter

leofolive avatar Nov 30 '21 16:11 leofolive

Any updates?

felri avatar Dec 10 '21 19:12 felri

@lawnstarter

Zzzhuk avatar Jan 05 '22 14:01 Zzzhuk

Any updates? Has this repository been abandoned?

leofolive avatar Jan 05 '22 17:01 leofolive

Why the PR has not been merged?

tomassvatek avatar Feb 14 '22 11:02 tomassvatek

@lawnstarter this PR has multiple approvals & would be very helpful, please merge or provide an update if you can. Thanks! :)

stevenvz avatar Mar 02 '22 20:03 stevenvz

Or is @LawnStarterTeam the correct @? ^

stevenvz avatar Mar 02 '22 22:03 stevenvz

  • 1

sophie-li avatar Mar 14 '22 21:03 sophie-li

Any updates on this, please? @LawnStarterTeam

sophie-li avatar Mar 31 '22 17:03 sophie-li

Any updates on this, please? @LawnStarterTeam

leofolive avatar Apr 04 '22 13:04 leofolive

Any updates? I think it's time to start a fork of this project and fix all these problems, working on it...

leofolive avatar Jul 28 '22 21:07 leofolive

use npm install react-native-picker-select-updated to get dark mode

awibox avatar Dec 15 '22 13:12 awibox