biscuit icon indicating copy to clipboard operation
biscuit copied to clipboard

Implement ECDH-ES

Open lawliet89 opened this issue 9 years ago • 4 comments

Probably not the AES**KW variants because ring does not seem to support AESKW.

lawliet89 avatar Apr 24 '17 03:04 lawliet89

is still in the works?

There is some mention of ECDH-ES in the source https://github.com/lawliet89/biscuit/blob/e578b4071fb7315dbe9d84d05b2d81672887151e/src/jwa.rs#L418 , what's currently missing?

vladikoff avatar Nov 16 '17 15:11 vladikoff

Support from the Crypto library (ring) is missing. I haven't had the time to implement it with Openssl instead.

On Thu, 16 Nov 2017, 23:38 Vlad Filippov, [email protected] wrote:

is still in the works?

There is some mention of ECDH-ES in the source https://github.com/lawliet89/biscuit/blob/e578b4071fb7315dbe9d84d05b2d81672887151e/src/jwa.rs#L418 , what's currently missing?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lawliet89/biscuit/issues/74#issuecomment-344961118, or mute the thread https://github.com/notifications/unsubscribe-auth/AA8APeZzAU7eYuHhjce_0Ea3ITFLAQ1Dks5s3FcEgaJpZM4NFp9F .

-- Regards Yong Wen

lawliet89 avatar Nov 17 '17 00:11 lawliet89

There are two PRs for ring to implement https://github.com/briansmith/ring/issues/331, which would allow this to be implemented using ring, I believe.

briansmith avatar Feb 06 '19 00:02 briansmith

Thanks @briansmith for letting me know. I'll keep a lookout.

lawliet89 avatar Feb 06 '19 00:02 lawliet89