Error Cannot install AppImage for ElDumper

[thimslugga]

It appears to copy the image to Applications so I'm guessing it's an issue related to extracting image and creating the desktop file since those are missing.

ayy install ~/Downloads/ElDumper.AppImage 
ERROR: Cannot install AppImage: %!s(PANIC=Error method: runtime error: invalid memory address or nil pointer dereference)

ls ~/Applications/ElDumper*
/var/home/thimslugga/Applications/ElDumper.AppImage

ls -Gg ~/.local/share/applications/
total 32
-rw-r-----. 1  309 May  3 21:55 appimage_ayy_dsk-systemkeyboardconfigurator.desktop
-rw-r-----. 1  395 Apr 30 11:52 devilutionx.desktop
-rw-r-----. 1  222 Apr  1  2021 firmware-reboot.desktop
-rw-r-----. 1 2561 Apr 24 13:33 htop.desktop
-rw-r-----. 1  231 Apr 13  2021 nintendont-sm64ex.desktop
-rw-r-----. 1  212 Apr  8 12:30 noisetorch.desktop
-rw-r-----. 1  241 Apr 28 15:34 org.wezfurlong.wezterm.desktop
-rw-r-----. 1  506 Apr 28 20:06 sublime_text.desktop

https://appimage.github.io/ElDumper/ https://github.com/rodri042/el-dumper

[lawl]

Thanks for reporting this. The error message there was definitely useless, so I've fixed that.

The issue here is that this AppImage is missing a ".DirIcon" file in it's directory root. You can verify this with ayy fs ElDumper.AppImage ls /.

According to the AppImage spec

MUST contain a .DirIcon file as per the AppDir specification which SHOULD be a 256x256 PNG file.

this must exist. So this AppImage is violating spec here. I think it may be worth contacting them and asking them to fix this?

They do have a png ready

Lrwxrwxrwx     0    0       0 B    May 12 2019 10:50  eldumper.png -> usr/share/icons/hicolor/0x0/apps/eldumper.png

They'd just need a symlink called .DirIcon also. If it turns out this is a bigger pattern in the AppImage ecosystem, then sure, we'll have to ignore the spec and work around it. But for now, this is n=1, so I'd like to wait.

Anyways, thank you for reporting, these are the exact kind of issues that are impossible without people actually using it!

[lawl]

Actually, I've already changed my mind on this, sorry!

Should work with master now.

AppImage spec sais above:

MAY contain an $APPICON.svg, $APPICON.svgz or $APPICON.png file in its root directory with $APPICON being the icon identifier as set in the Icon= key of the $APPNAME.desktop

Seems reasonable to use that as a fallback if no .DirIcon is found.

[probonopd]

ERROR: Cannot install AppImage

AppImags don't need to be installed. It is sufficient to download them, set the executable bit, and run them.

EDIT: No offense meant @lawl. I am just watching GitHub for issues with AppImage, clarify concepts, try to remove misunderstandings, and try to be generally helpful to help the adoption of the AppImage format. Feel free to contact me if you have any questions or concerns regarding the AppImage format.

[lawl]

@probonopd you have mentioned that already in lawl/NoiseTorch. Please read what the purpose of this project is. I don't care if you disagree with me calling the creation of a desktop entry installing or not. This project does it.

If you have any concerns, you are also free to talk to me in matrix or IRC. Otherwise, if you have nothing to contribute here, I'd ask you to refrain from doing so, or I will block you from being able to comment on my repositories. Thank you.

[thimslugga]

Np @lawl appreciate you taking a look. I'll build from latest master and do some more testing with some more AppImages.