Lavalink icon indicating copy to clipboard operation
Lavalink copied to clipboard

Missing option to disable native audio

Open Fabricio20 opened this issue 7 years ago • 4 comments

When testing LavaLink on new systems it would be nice to have a config option to disable native audio sending, since the internal checks do not account for new kernels/systems.

LavaLink seems to default NAS to enabled, making it impossible to test the resources on (currently) unsupported systems like linux-aarch64.

Fabricio20 avatar Jan 07 '18 08:01 Fabricio20

Feel free to add a switch to turn it off

On a sidenote, Lavaplayer generally performs very poorly on ARM.

freyacodes avatar Jan 07 '18 10:01 freyacodes

This doesn't look to be very easy - looks like this would require a modification to JDAA unless it has its own internal null checks for the AudioSendFactory

devoxin avatar Mar 04 '18 02:03 devoxin

Lavaplayer does, you can run it without JDA-NAS which is what he's talking about I'm pretty sure. It's not hard to recompile Lavalink without JDA-NAS, but as Fred said it's something I would definitely recommend.

shikhir-arora avatar Mar 04 '18 02:03 shikhir-arora

Time so clear up some misconceptions:

  1. JDA uses its own AudioSendFactory when one isn't explicitly set
  2. We enabled NAS at runtime https://github.com/Frederikam/Lavalink/blob/master/LavalinkServer/src/main/java/lavalink/server/Launcher.java#L126
  3. NAS doesn't really have much to do with lavaplayer

freyacodes avatar Mar 04 '18 09:03 freyacodes

implemented in https://github.com/freyacodes/Lavalink/releases/tag/3.7.0

topi314 avatar Jan 14 '23 21:01 topi314