Document adler32 hashing algorithm

Open rillig opened this issue 10 years ago • 1 comments

The Adler32 checksumming algorithm in src/core/hash/adler.c needs to be documented and verified that it meets its specification. Currently it fails on x86 because char is a signed data type on that platform. See https://github.com/lavabit/libdime/blob/master/check/core/check_hash.c for the check in libdime.

May 26 '15 19:05 rillig

Am 26.05.2015 um 22:46 schrieb Ivan:

I believe this is one of the things that Roland already fixed in libdime/libs/core, but is still an issue in magma.classic.

If you pull down libdime from github and you do a diff between the two files you will see the changes. There is also a unit test that he wrote that he linked to which does not exist in magma.

Confirmed.

Roland

May 26 '15 21:05 rillig