magma icon indicating copy to clipboard operation
magma copied to clipboard

We need an enumerated type for data type in fields returned by database queries.

Open LBiv opened this issue 10 years ago • 2 comments

Going to put every instance that I see where this replacement needs to occur here:

src/servers/smtp/datatier.c lines 199-232 src/servers/smtp/datatier.c lines 293-300 src/servers/smtp/datatier.c lines 636-647

LBiv avatar Jun 22 '15 17:06 LBiv

Same code: line 116: int_t smtp_fetch_inbound()

  • This routine needs enum types for describing the error return values
  • Also needs enum types for the user record's lock levels that are checked starting line 171. Adding enum for lock levels will require a sweep throughout the codebase to apply that enum to all lock level references, which will require a sweep that's broader than the smtp.c code, right?

kenthawk avatar Jun 22 '15 18:06 kenthawk

Yes, enums for errors would be nice too.

LBiv avatar Jun 23 '15 00:06 LBiv