lava icon indicating copy to clipboard operation
lava copied to clipboard

Plateau Neuron - Fixed Point Model

Open kds300 opened this issue 2 years ago • 4 comments

Issue Number: #775

Objective of pull request: Add Plateau neuron model to lava as described in the above issue.

Pull request checklist

Your PR fulfills the following requirements:

  • [x] Issue created that explains the change and why it's needed
  • [x] Tests are part of the PR (for bug fixes / features)
  • [ ] Docs reviewed and added / updated if needed (for bug fixes / features)
  • [x] PR conforms to Coding Conventions
  • [x] PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • [x] Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • [x] Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation changes
  • [ ] Other (please describe):

What is the current behavior?

  • There is no current behavior, this is a new model.

What is the new behavior?

  • The model will take two separate inputs, one to the "soma" and another to the "dendrite". Both the soma and dendrite potentials will follow sub-threshold LIF dynamics. When the dendrite potential crosses its threshold it resets and sends the neuron to the UP state. The UP state will last for a specified duration of time steps. During this time, the soma is able to spike and reset if its potential crosses its threshold. If the neuron is in the DOWN state, the soma potential will follow subthreshold LIF dynamics regardless of whether it crosses the threshold.

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

Supplemental information

kds300 avatar Sep 01 '23 00:09 kds300

Hi @kds300, Thanks for this PR. Sorry it took us so long to take a look.

Pushed a PR to https://github.com/kds300/lava/pull/7 that should fix the codacy issues.

I will do more review in the next few days and I've added a few others for comment and review.

mgkwill avatar Oct 18 '23 06:10 mgkwill

Thanks for your contribution. Great code quality!

Just a few minor points I would ask you to change.

Please reach out if you have any questions.

Thanks for the feedback! I'll go through code and make the requested changes.

kds300 avatar Oct 18 '23 14:10 kds300

I updated my local branch with several of the recommended changes, and commented on some of the requested changes that I have questions about.

kds300 avatar Oct 19 '23 18:10 kds300

Hi @kds300, Thanks for this PR. Sorry it took us so long to take a look.

Pushed a PR to kds300#7 that should fix the codacy issues.

I will do more review in the next few days and I've added a few others for comment and review.

@mgkwill Thanks for fixing the codacy issues! I'm still a bit new to github, especially using it collaboratively, so I had started making changes before merging that pull request. I added a commit to sort out some of the merge conflicts I created and then merged the pull request.

kds300 avatar Oct 19 '23 19:10 kds300