lava icon indicating copy to clipboard operation
lava copied to clipboard

Add loglevel to PyLoihiProcessModel.__init__

Open tim-shea opened this issue 2 years ago • 0 comments

Issue Number: #760

Objective of pull request: Add loglevel paramater to PyLoihiProcessModel constructor

Pull request checklist

Your PR fulfills the following requirements:

  • [X] Issue created that explains the change and why it's needed
  • [X] Tests are part of the PR (for bug fixes / features)
  • [X] Docs reviewed and added / updated if needed (for bug fixes / features)
  • [X] PR conforms to Coding Conventions
  • [X] PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • [X] Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • [X] Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • [X] Bugfix

What is the current behavior?

  • User cannot override the default loglevel of a PyLoihiProcessModel.

What is the new behavior?

  • User can provide a loglevel parameter to the PyLoihiProcessModel constructor which will be forwarded to the AbstractPyProcessModel constructor, leading to a different loglevel being set for the process model log.

Does this introduce a breaking change?

  • [X] No

tim-shea avatar Aug 01 '23 19:08 tim-shea