lava icon indicating copy to clipboard operation
lava copied to clipboard

PyProcessBuilder: Combine Py-/Ref-/VarPort initialization

Open PhilippPlank opened this issue 4 years ago • 2 comments

User story

As an NCL developer, I want the PyProcessBuilder to use the same code to initialize PyPorts, RefPorts, and VarPorts in the build() method to avoid code duplication.

Currently the initialization of PyPorts, RefPorts and VarPorts is done separately within the build() method, although they share common code. Ideally a helper method is created to handle the initialization of the different types of Ports, which can then be called within the build() method.

The code lives in lava/src/lava/magma/compiler/builders/py_builder.py

Note: This is not a full user story because it is only a refactoring effort that has no direct value to external customers.

Conditions of satisfaction

  • Code duplication in initializing PyPorts, RefPorts, and VarPorts in the PyProcessBuilder is removed.

PhilippPlank avatar Nov 16 '21 09:11 PhilippPlank

Could you provide a few more details for whoever picks this up?

awintel avatar Nov 16 '21 20:11 awintel