lava icon indicating copy to clipboard operation
lava copied to clipboard

Enable tutorials on Windows

Open PhilippPlank opened this issue 3 years ago • 1 comments

Issue Number: #95 and #148

Objective of pull request: All tutorials should work on Windows systems

Pull request checklist

Your PR fulfills the following requirements:

  • [x] Issue created that explains the change and why it's needed
  • [x] Tests are part of the PR (for bug fixes / features)
  • [x] Docs reviewed and added / updated if needed (for bug fixes / features)
  • [x] PR conforms to Coding Conventions
  • [x] PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
  • [x] Lint (flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally
  • [x] Build tests (pytest) passes locally

Pull request type

Please check your PR type:

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation changes
  • [ ] Other (please describe):

What is the current behavior?

  • The tutorial execution stalls

What is the new behavior?

  • The tutorial executes all cells as expected

Does this introduce a breaking change?

  • [ ] Yes
  • [x] No

PhilippPlank avatar Jun 14 '22 17:06 PhilippPlank

I realized that the solution only works for tutorial 02, for the other tutorials things get more complex because Processes get overwritten.

There is some cleanup necessary, but @awintel, could you please take a look at this updated solution?

weidel-p avatar Jun 16 '22 16:06 weidel-p