lava
lava copied to clipboard
Virtual ports inherit capabilities of their parent ports (#234)
Signed-off-by: Mathis Richter [email protected]
Issue Number: #234
Objective of pull request: Virtual ports should inherit the capabilities of their parent ports
Pull request checklist
Your PR fulfills the following requirements:
- [x] Issue created that explains the change and why it's needed
- [x] Tests are part of the PR (for bug fixes / features)
- [x] Docs reviewed and added / updated if needed (for bug fixes / features)
- [x] PR conforms to Coding Conventions
- [x] PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
- [x] Lint (
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally - [x] Build tests (
pytest) passes locally
Pull request type
Please check your PR type:
- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation changes
- [ ] Other (please describe):
What is the current behavior?
- When a virtual port is created, it has a number of generic capabilities, like connecting. But when creating a virtual port on a RefPort, the user cannot use the connect_var() method on the virtual port.
What is the new behavior?
- When a virtual port is created, it inherits those capabilities of its parent port that make sense for the virtual port. This includes
connect_var()from RefPort.
Does this introduce a breaking change?
- [ ] Yes
- [x] No
Supplemental information
Apparently something is wrong with the new library dependency I added. Will look into this asap.