lava
lava copied to clipboard
lava-nc
Nc monitor
Issue Number: #228
Objective of pull request: To provide unittests for demonstrating updated API for new Monitor design
Pull request checklist
Your PR fulfills the following requirements:
- [X] Issue created that explains the change and why it's needed
- [X] Tests are part of the PR (for bug fixes / features)
- [ ] Docs reviewed and added / updated if needed (for bug fixes / features)
- [X] PR conforms to Coding Conventions
- [X] PR applys BSD 3-clause or LGPL2.1+ Licenses to all code files
- [ ] Lint (
flakeheaven lint src/lava tests/) and (bandit -r src/lava/.) pass locally - [ ] Build tests (
pytest) passes locally
Pull request type
Please check your PR type:
- [ ] Bugfix
- [ ] Feature
- [X] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation changes
- [ ] Other (please describe):
What is the current behavior?
- There are unittests for current version of the Monitor class
What is the new behavior?
- New (but failing) unittests for Monitor class are added to showcase and collect feedback for new API. Corresponding implementation of the new design is not here yet
Does this introduce a breaking change?
- [X] Yes
- [ ] No
This PR is a draft and is not meant to merged yet, rather to collect feedback for new API of Monitor
Supplemental information
@mathisrichter I have some of fine-grained tests for old API, they just need to be adapted to the new API