refined-github-safari icon indicating copy to clipboard operation
refined-github-safari copied to clipboard

How do we keep this up to date with changes to Refined Github?

Open wearhere opened this issue 5 years ago • 4 comments

Especially if we're building the app ourselves to add support for GitHub Enterprise https://github.com/lautis/refined-github-safari/issues/8#issuecomment-475241086.

wearhere avatar Oct 01 '20 18:10 wearhere

There's two sides for this:

  1. How to keep the codebase up-to-date with refined-github
  2. How to keep app installations updated

For the second problem, publishing to Mac App Store would seem to be the best option. Unfortunately that process is not instant and trademarks might make it harder to get to the App Store. Homebrew seems like a reasonable fallback option but requires user interaction. I guess having Sparkle or similar self-update functionality wouldn't hurt. However, they require user interaction, and I don't at least open the .app very often.

To keep things up-to-date is rather simple by running fastlane update_refined_github. That would be easy to automate with GitHub Actions, but then also having automation to publish new versions would be needed to provide value.

1 and 2 are a bit conflicting unless confidence for automation would be high enough to publish to App Store without any manual checks.

lautis avatar Oct 02 '20 12:10 lautis

As for GitHub Enterprise, it might be easiest to implement a second extension running all domains and via app settings control which domains actually load the code. Unless changing manifest within runtime is allowed in Safari 14.

lautis avatar Oct 02 '20 12:10 lautis

As for GitHub Enterprise, it might be easiest to implement a second extension running all domains and via app settings control which domains actually load the code

Is this through additional inputs in the extension's settings view?

notlmn avatar Oct 02 '20 13:10 notlmn

GitHub access token is set through the .app, but I haven’t looked at how it should work with WebExtensions API or what the implementation in refined-github now looks like.

lautis avatar Oct 02 '20 16:10 lautis