Laurenz
Laurenz
I think this is derailing a bit. I wouldn't want to replace the "unexpected argument" error everywhere. The message above is a bit verbose and technical in my opinion. I...
This LGTM apart from one thing: The VS Code test helper extension has some issues now. This line needs adjustment with the parameters https://github.com/typst/typst/blob/bc3d0e580d436f9c0628cdb07fa1b6f07aa9e655/tools/test-helper/src/extension.ts#L127 And the preview also does not...
First of all: Sorry for the late reply. I am a bit concerned by moving all of the logic from typst-pdf into typst-cli. In my opinion, as much of the...
I'll close this for now due to inactivity. We can always reopen or have a new PR.
@drupol As resident Nix expert, do you have an idea what's going on?
Can't we use the existing crate feature that vendors OpenSSL?
> Enable the vendored feature of openssl in typst-kit It should not be enabled by default outside of Nix. It's intentionally opt-in.
There is this function, which could be used: https://github.com/typst/typst/blob/3d64f7b659905755322c419c5cd1fdb2078590e8/crates/typst-syntax/src/lexer.rs#L1084-L1085 And then, there's existing logic in `repr` to show `label("..")` instead of `` if it's not valid syntax: https://github.com/typst/typst/blob/3d64f7b659905755322c419c5cd1fdb2078590e8/crates/typst-library/src/foundations/label.rs#L92-L101 I could...
Thinking about this further: What if we don't make a syntactical distinction at all (still fixing the bug that it gives invalid labels of course) but rather check whether the...
@bluss What do you think about the idea of checking whether the target element is referenceable?