most-active-github-users-counter icon indicating copy to clipboard operation
most-active-github-users-counter copied to clipboard

Restrict contributions to commits that are authored by the contributors?

Open bzg opened this issue 5 years ago • 8 comments

First of all, nice project, thanks for maintaining it!

There are users with +10000 "contributions" - I guess some of them are committers for commits they didn't directly authored, but rather delegated to a bot or whatever CI action.

Would it make sense to restrict the default ranking contributions = commits = commits-authored?

bzg avatar Mar 13 '20 05:03 bzg

Hi & thanks! Hmm that actually sounds quite interesting - that way the list would actually reflect the actual commit count and not contribution count. I think I'll explore that option at some point so I'll keep this issue open for now until I have time to take a look :+1:

lauripiispanen avatar Mar 13 '20 13:03 lauripiispanen

Thank you!

bzg avatar Mar 13 '20 22:03 bzg

Hi @lauripiispanen - just quietly chiming in to say that I'm still interested in this.

Btw, is there a way to support your volontary work on such projects?

bzg avatar Aug 01 '20 13:08 bzg

Hi, I hope the Covid crisis did not hurt you in any way - is this issue something that you still want to do? Thanks for any news!

bzg avatar Mar 26 '21 08:03 bzg

Hi, I hope things are fine on your end - just checking if, by any chance, you had the time to look at this.

Maybe my friend @antoineaugusti may have some time to look at this?

bzg avatar Sep 17 '21 07:09 bzg

Or maybe my other friend @guillim?

bzg avatar Oct 03 '21 06:10 bzg

Maybe it has already been done in https://github.com/lauripiispanen/most-active-github-users-counter/commit/32519d023d82fa42e646d46e4228620bd9bd883c?

AntoineAugusti avatar Oct 04 '21 08:10 AntoineAugusti

From a cursory look, I believe this commit is more about completing the set of "contributions" (adding private contribution count and pull request), rather than reducing the notion of contribution to the set of commits where the commit author is also the author of the push. Or maybe I miss something?

bzg avatar Oct 04 '21 08:10 bzg