drupalcores icon indicating copy to clipboard operation
drupalcores copied to clipboard

Credit Revert of Revert

Open claudiu-cristea opened this issue 8 years ago • 1 comments

Read next commit messages:

Revert "Revert "Issue #2241633 by sun: Simplify site-specific service overrides.""

Revert "Revert "Issue #2457653 by Gábor Hojtsy: System.site langcode is both used as a file language code and a site language code""

Revert "Revert "Issue #2489922 by anavarre, RavindraSingh: Fix minor typos""

Revert "Revert "Issue #2510104 by pwolanin, nod_, Fabianx, Wim Leers, droplet, Pere Orga: Convert drupalSettings from JavaScript to JSON, to allow for CSP in the future""

Revert "Revert "Issue #2761403 by Berdir: Move runtime theme registry into bootstrap cache""

Revert "Revert "Issue #2834291 by claudiu.cristea, Berdir, amateescu, timmillwood, catch: Add a SQL index for entity types that are using EntityPublishedInterface""

Because of the revert regexp in json.rb

reverts_regexp = Regexp.new '^Revert \"(?<credits>.+#[0-9]+.* by [^:]+:).*'
reverts_regexp_loose = Regexp.new '^Revert .*(?<issue>#[0-9]+).*'

...these commit messages are considered reverts and are not credited. But these are valid contributions because the original commit was reverted (the contributor is not credited) and, then, the revert is reverted -- as a consequence this is the commit where the contribution gets in and the contributor should be credited.

claudiu-cristea avatar Jan 01 '17 15:01 claudiu-cristea

Seems like this should still land.

wimleers avatar Dec 06 '17 17:12 wimleers