angular-payments icon indicating copy to clipboard operation
angular-payments copied to clipboard

cvc field freeze when 4 characters(Firefox)

Open 1xch opened this issue 10 years ago • 11 comments

Putting 4 characters into the cvc field freezes any editing of the cvc field.

It will read as ng-dirty ng-valid ng-valid-cvc, however it becomes uneditable(Firefox only, not Chromium, untested in other browsers), unable to delete, backspace, or change.

No console output --- no apparent error anywhere.

1xch avatar May 29 '14 17:05 1xch

Just discovered this too.

kencaron avatar Jun 20 '14 18:06 kencaron

This is a valid bug. Causes due to incorrect detection of the backspace key in _formatCVC ( https://github.com/laurihy/angular-payments/blob/master/lib/angular-payments.js#L331 )

kapeels avatar Jun 21 '14 07:06 kapeels

This is one of the pending PR that apparently solves the issue - https://github.com/laurihy/angular-payments/pull/23/files

I added if( e.charCode == 0 ) return; after line 334 in lib/angular-payment.js

kapeels avatar Jun 21 '14 07:06 kapeels

Thanks @kapeels & @dmgts, that will work as a temporary patch.

kencaron avatar Jun 23 '14 17:06 kencaron

This is a pretty serious issue, it is breaking our checkout form on Firefox where you can't edit the CVC number after you type in 4 characters.

I tried adding if( e.charCode == 0 ) return; but that only fixes the backspace button but ctrl-a selecting of the text and trying to modify it still doesn't work.

dmix avatar Jul 24 '14 17:07 dmix

I can confirm this issue on firefox. I will try to find a fix for this too.

tomazahlin avatar Sep 03 '14 14:09 tomazahlin

+1

barszczmm avatar Nov 15 '14 10:11 barszczmm

When will this be fixed and merged with master?

achinth avatar Dec 09 '14 07:12 achinth

it is very critical bug :+1:

hyzhak avatar Dec 25 '14 19:12 hyzhak

I've got a PR open, and if you want to test it out, just update your bower.json to point to: "angular-payments": "[email protected]:Fullscreen/angular-payments.git#ff-compat"

8bitDesigner avatar Jan 14 '15 21:01 8bitDesigner

Fixed in master here: https://github.com/Fullscreen/angular-payments

8bitDesigner avatar Jan 20 '15 18:01 8bitDesigner