angular-payments
angular-payments copied to clipboard
cvc field freeze when 4 characters(Firefox)
Putting 4 characters into the cvc field freezes any editing of the cvc field.
It will read as ng-dirty ng-valid ng-valid-cvc, however it becomes uneditable(Firefox only, not Chromium, untested in other browsers), unable to delete, backspace, or change.
No console output --- no apparent error anywhere.
Just discovered this too.
This is a valid bug. Causes due to incorrect detection of the backspace key in _formatCVC ( https://github.com/laurihy/angular-payments/blob/master/lib/angular-payments.js#L331 )
This is one of the pending PR that apparently solves the issue - https://github.com/laurihy/angular-payments/pull/23/files
I added if( e.charCode == 0 ) return;
after line 334 in lib/angular-payment.js
Thanks @kapeels & @dmgts, that will work as a temporary patch.
This is a pretty serious issue, it is breaking our checkout form on Firefox where you can't edit the CVC number after you type in 4 characters.
I tried adding if( e.charCode == 0 ) return; but that only fixes the backspace button but ctrl-a selecting of the text and trying to modify it still doesn't work.
I can confirm this issue on firefox. I will try to find a fix for this too.
+1
When will this be fixed and merged with master?
it is very critical bug :+1:
I've got a PR open, and if you want to test it out, just update your bower.json to point to:
"angular-payments": "[email protected]:Fullscreen/angular-payments.git#ff-compat"
Fixed in master here: https://github.com/Fullscreen/angular-payments