oracle_fdw icon indicating copy to clipboard operation
oracle_fdw copied to clipboard

oracle_fdw parameters or transaction options possible?

Open pauldzy opened this issue 6 years ago • 4 comments

Hi Laurenz,

I have not entirely forgotten about #245. However overall it seems that geometry translation is rather slow and adding additional logic to check the orientation of polygon rings will just make it slower. Ideally it would be swell to have this be optional behavior. However I do not exactly see how oracle_fdw could or should accept logic conditions per transaction.

What I mean is perhaps I have 3 million polygons in my system which I know are oriented correctly and I do not wish to have their orientations checked. Or perhaps I have 3 millions polygons from unknown source which may or may not be oriented correctly and I want to verify the orientation perhaps on the first load into my system (and thereafter is not needed). Is oracle_fdw really setup for this kind of conditional processing? I just don't see any other functionality doing this.

Paul

pauldzy avatar Jul 17 '18 14:07 pauldzy

Hmm, it should be quite fast to read Oracle geometries via oracle_fdw. Updating or inserting many Oracle geometries is slow, but that's a general problem of oracle_fdw which updates or inserts each row individually. Are you reading or writing?

I am not certain what you mean by making such a check optional. Currently there is no such check, right? So are you wondering how to write a patch that optionally checks polygon orientation?

In that case the answer would be to make this a FDW option, probably on the table, like max_long or prefetch. This can be set and reset at will. Of course you could also add a new GUC oracle_fdw.check_polygon_orientation. Hard to say which is better.

laurenz avatar Jul 17 '18 16:07 laurenz

What is the state on this?

laurenz avatar Sep 18 '18 16:09 laurenz

hello, well its still under consideration. :) but do close the ticket for now if its cluttering up the list.

pauldzy avatar Sep 18 '18 20:09 pauldzy

Let's leave it open. This was just a keepalive packet.

laurenz avatar Sep 19 '18 07:09 laurenz

Four years later: shall we still keep this open?

laurenz avatar Nov 24 '22 08:11 laurenz