GitDiffMargin icon indicating copy to clipboard operation
GitDiffMargin copied to clipboard

Published 20 hours ago • verified publisher icon laurentkempe

Charp73

Open laurentkempe opened this issue 5 years ago • 5 comments

laurentkempe avatar Aug 25 '18 14:08 laurentkempe

Looks like a fun PR. I'll go through it!

sharwell avatar Aug 25 '18 16:08 sharwell

@sharwell Nice ! But I am not finished

laurentkempe avatar Aug 25 '18 17:08 laurentkempe

This commit is more than I can deal with. Hopefully it's all correct...

@sharwell I will split this PR in multiple one ok ?

laurentkempe avatar Aug 27 '18 12:08 laurentkempe

My biggest recommendation is if you are hoping/planning to settle on a consistent style, use StyleCop Analyzers to enforce the desired style during the build. Otherwise it's too easy for the project to start to deviate.

sharwell avatar Aug 28 '18 12:08 sharwell

In the end, the decision is up to you. I'm not a fan of the way this tool applies formatting, but it's not my project so I don't make the rules

@sharwell I have to say that I am not a big fan neither at the moment of the formatting! It might be not your project but your participate quite a lot on it, so it is always good to get your ideas/feeling... I will reconsider all of this and will first make a PR which just change the whole thing to C# 7.3! For the rest we will see

laurentkempe avatar Aug 28 '18 16:08 laurentkempe