rsync-time-backup
rsync-time-backup copied to clipboard
laurent22
Is this repo maintained?
I'm seeing a few open PRs with no replies from @laurent22 and no replies on a few recent issues. Maybe @laurent22 no longer has time to maintain the script?
Is anyone maintaining a fork they can recommend as a starting point instead?
I'm indeed lacking time to maintain this repo. The most important issue is with the backup deletion schedule, but it's not an easy fix. Other PR I might check at some point.
@laurent22 Sweet, thanks for the instant reply. Are you open to handing over to somebody if there's someone willing to take over maintenance?
I'm not in that position, but maybe somebody who's submitted a PR, etc, could be.
Hmm, maybe but I don't know who at this point. One has to be extremely careful when updating this script because it's used in many automated scripts, so if I hand it over to someone just because they're interested, it's a risk. Maybe they'll update the script to fit their use case only and break existing crons, or even worse, they could update it for malicious purposes (as it happens recently for a node package that was handed over too easily).
If someone had contributed regularly over many years, I would hand it over to them, but unfortunately there's no such person.
I agree with @laurent22. Everybody can maintain their own fork if desired but this original has been very well maintained and stable
@laurent22 Makes a lot of sense. Also good advice to consider for any project that has security implications, I'll keep that in mind. Maybe adding people slowly to the project happens over the next few years. Thanks for all the work you've put into this.
Might be worth having an issue open for adding tests or something so we can be more confident about what features are supported? Maybe start writing tests in bash and run with bats or at least documenting future plans? Even just a test suite that fails but has all the features listed is a great start, then people can start plucking them off. I'm thinking more integration tests rather than unit tests but both would be great. Never done this sort of thing in bash but it could be fun.
Also here's one example project that has bash tests: https://github.com/p8952/bocker
oh missed this convo before I started on it: checkout PR #205 for adding tests @mandric ... no tests yet but adds functional testing (bash doesn't really have bite-sized units (other than script files) to unit-test like say python)
thoughts and feedback welcome on PR #205
