rsync-time-backup icon indicating copy to clipboard operation
rsync-time-backup copied to clipboard

fix #116 allow backup directory with spaces

Open Wikinaut opened this issue 6 years ago • 2 comments

@laurent22 here's a formal PR. Attention: I haven't tested it!

Wikinaut avatar May 09 '18 22:05 Wikinaut

It seems the pull request sometimes adds two pairs of double quotes, and sometimes one pair of double and one pair single quotes. For example:

"\'$DEST_FOLDER/\'"

"\"$INPROGRESS_FILE\""

That would result in:

"'my/path'"

""my/path""

Is there any reason for this?

Edit: Sorry just saw you haven't tested it, but obviously this needs to be tested as we don't want to break people's backup scripts.

laurent22 avatar May 17 '18 12:05 laurent22

+1. For me that has solved the problem. ( directory with spaces in destination backup dir)

ventoh avatar Nov 22 '18 07:11 ventoh