joplin icon indicating copy to clipboard operation
joplin copied to clipboard

When printing sync target info to the log, filter the data

Open laurent22 opened this issue 1 year ago • 3 comments

Currently during sync, the full sync info is printed to the log. It contains a lot of unnecessary information and should be filtered out:

  • masterKeys_: The content and checksum properties should be removed
  • ppk_.value.privateKey: The first 20 characters and last 20 characters should be kept, and the rest removed (replaced by "...")
  • ppk_.value.publicKeyKeep the first 40 characters

laurent22 avatar Feb 23 '24 15:02 laurent22

I understood the issue, but I am not able to find where have we defined sync Info schema, also when you are talking about the log where are you pointing exactly?

Sanket-0510 avatar Feb 24 '24 17:02 Sanket-0510

ppk_.value.privateKey: The first 20 characters and last 20 characters should be kept, and the rest removed (replaced by "...") ppk_.value.privateKeyKeep the first 40 characters

I am having confusion do you want to keep first 40 characters or the first point??

Nainish-Rai avatar Feb 24 '24 18:02 Nainish-Rai

ppk_.value.privateKey: The first 20 characters and last 20 characters should be kept, and the rest removed (replaced by "...") ppk_.value.privateKey:Keep the first 40 characters

I think one of them shoul be ppk_.value.publicKey

Gurpreetk9 avatar Feb 25 '24 06:02 Gurpreetk9