joplin
joplin copied to clipboard
laurent22
Android: typing auto-correction does not work when using the beta editor
On Android, when using the beta editor, the typing corrections on my keyboard (Gboard) are shown but are not accepted automatically when I enter a space after the word.
Environment
Joplin version: 2.6.8 Platform: Android OS specifics:
Steps to reproduce
- Activate the beta editor
- Edit a note and type some text with a wrong word for which the keyboard suggest a correction
- Enter a space
- The suggested correction is not used
Describe what you expected to happen
I would expect the word to be auto-corrected when I enter a space, just like in the standard editor (note that the suggested correction is in bold here, meaning that entering a space will auto-correct the word):
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Comment to keep alive the issue as it's still affecting me (@tessus anything else I should do?)
Also, I have the feeling that the problem behind this issue is the same as https://github.com/laurent22/joplin/issues/5987.
I wonder if this is an issue with CodeMirror6 (the library we're using for the beta editor).
Does something similar happen with the editor on the library Joplin uses (CodeMirror's) homepage? I'm interested in whether this problem stems from an issue with Joplin or an issue with CodeMirror (or maybe an issue with the version of CodeMirror we're using).
Because CodeMirror is a code-editor, it might be disabling auto-complete intentionally...
I wonder if this is an issue with CodeMirror6 (the library we're using for the beta editor).
Does something similar happen with the editor on the library Joplin uses (CodeMirror's) homepage? I'm interested in whether this problem stems from an issue with Joplin or an issue with CodeMirror (or maybe an issue with the version of CodeMirror we're using).
Because CodeMirror is a code-editor, it might be disabling auto-complete intentionally...
From the CodeMirror6 implementation on codemirror.net, it looks like they are intentionally disabling autocorrect:
We should be able to toggle this from within Joplin. Please see CodeMirror.ts (where we set up styling for the editor) and NoteEditor.tsx (where we create the editor).
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Spellcheck was enabled in the beta editor -- this might be fixed in the next release.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? If you require support or are requesting an enhancement or feature then please create a topic on the Joplin forum. This issue may be closed if no further activity occurs. You may comment on the issue and I will leave it open. Thank you for your contributions.
Spellcheck was enabled in the beta editor -- this might be fixed in the next release.
@personalizedrefrigerator I've just updated to the latest stable version on Android (2.9.8), but it looks like the bug is still there. The spellcheck option is enabled. Am I missing something?
See #7532. autocorrect was explicitly disabled by CodeMirror. Manually enabling autocorrect with spellcheck seems to fix the issue.
Sorry for not fixing this originally! (I personally use the "clip"/auto-replace feature of my keyboard, which does seem to auto-replace with autocorrect explicitly disabled by CodeMirror.)
@personalizedrefrigerator Thanks a lot for the quick Christmas fix! When you say "manually enabling", do you mean in the code for the next release or can it be done manually in the stable release?
And could you explain what you mean by "clip"/auto-replace feature?
When you say "manually enabling", do you mean in the code for the next release or can it be done manually in the stable release?
I mean in the code for the next release. While it's possible to manually enable through the developer tools, doing so requires connecting the Android device to a computer with the Chrome developer tools running for each new instance of the editor.
And could you explain what you mean by "clip"/auto-replace feature?
The keyboard I'm using (Microsoft SwitfKey) has a "clip" feature (under clipboard settings) that allows manually specifying a list of replacements. For example, gt might be replaced with >. Samsung keyboard has a similar feature. The SwiftKey keyboard automatically replaces text in the list of replacements just after the user finishes typing it with the replacement. A space might be needed after the text for the automatic replacement to happen. This feature still seems to work if autocorrect is set to false by CodeMirror.